vtd: Don't do FLR when we create domain or hotplug device into guest.

VT-d hot-plug is done in such a way:  1) xend sends 'pci-ins' command
to ioemu via xenstore; 2) ioemu creates pass-through device and raises
SCI to guest OS; guest OS loads device driver, and device driver
initializes the hot-plugged device; 3) xend does FLR. There is a race
condition about 2) and 3). If 3) runs slow, we have troubles. Thanks
for Yuji Shimada's locating the issues.

We can work around the issues by not doing FLR when we create domain
or hotplug device into guest, namely, we only do FLR when we destroy
domain or hotplug device from guest.

Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
This commit is contained in:
Keir Fraser committed 2008-08-19 10:51:41 +01:00
1 parent d74b976c41
commit 154ef9e3cc
1 file changed
+6 -2
+6 -2
View File
@@ -290,8 +290,12 @@ class PciController(DevController):
self.CheckSiblingDevices(fe_domid, dev)
if arch.type != "ia64":
dev.do_FLR()
# We don't do FLR when we create domain and hotplug device into guest,
# namely, we only do FLR when we destroy domain or hotplug device from
# guest. This is mainly to work around the race condition in hotplug code
# paths. See the changeset's description for details.
# if arch.type != "ia64":
# dev.do_FLR()
PCIQuirk(dev.vendor, dev.device, dev.subvendor, dev.subdevice, domain,
bus, slot, func)
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.