blktap2: make protocol specific usage of shared sring explicit

I don't think protocol specific data really belongs in this header
but since it is already there and we seem to be stuck with it let's at
least make the users explicit lest people get caught out by future new
fields moving the pad field around.

This is the Xen portion of this change. The kernel portion will be
sent separately. There is no dependency between the two.

Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Daniel Stodden <daniel.stodden@citrix.com>
Cc: Dongxiao Xu <dongxiao.xu@intel.com>
This commit is contained in:
Keir Fraser committed 2010-07-02 18:58:02 +01:00
1 parent ac9fb79947
commit 1b9cecdb88
2 files changed
+11 -3

No files matched your search

+1 -1
View File
@@ -1684,7 +1684,7 @@ tapdisk_vbd_check_ring_message(td_vbd_t *vbd)
if (!vbd->ring.sring)
return -EINVAL;
switch (vbd->ring.sring->pad[0]) {
switch (vbd->ring.sring->private.tapif_user.msg) {
case 0:
return 0;
+10 -2
View File
@@ -103,8 +103,16 @@ union __name##_sring_entry { \
struct __name##_sring { \
RING_IDX req_prod, req_event; \
RING_IDX rsp_prod, rsp_event; \
uint8_t netfront_smartpoll_active; \
uint8_t pad[47]; \
union { \
struct { \
uint8_t smartpoll_active; \
} netif; \
struct { \
uint8_t msg; \
} tapif_user; \
uint8_t pvt_pad[4]; \
} private; \
uint8_t pad[44]; \
union __name##_sring_entry ring[1]; /* variable-length */ \
}; \
\
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.