From 236fc9fdf97f4e7c64824ab793e8dca30dd54ffb Mon Sep 17 00:00:00 2001 From: Nicola Vetrini Date: Wed, 9 Aug 2023 15:59:40 +0200 Subject: [PATCH] xen/delay: address MISRA C:2012 Rule 5.3 The variable 'msec' declared in the macro shadows the local variable in 'ehci_dbgp_bios_handoff', but to prevent any future clashes with other functions the macro is converted to a static inline function. No functional change. Signed-off-by: Nicola Vetrini Reviewed-by: Julien Grall --- xen/include/xen/delay.h | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/xen/include/xen/delay.h b/xen/include/xen/delay.h index 9d70ef035f..9150226271 100644 --- a/xen/include/xen/delay.h +++ b/xen/include/xen/delay.h @@ -4,7 +4,11 @@ /* Copyright (C) 1993 Linus Torvalds */ #include -#define mdelay(n) (\ - {unsigned long msec=(n); while (msec--) udelay(1000);}) + +static inline void mdelay(unsigned long msec) +{ + while ( msec-- ) + udelay(1000); +} #endif /* defined(_LINUX_DELAY_H) */