From 2b51691c8c7dccd39d0824fa1158078f23261ccb Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 20 Feb 2026 17:25:34 +0000 Subject: [PATCH] xen/vmac: Delete STDINT block in vmac.h Eclair reports that _MSC_VER is undefined, a MISRA Rule 20.9 violation. This could be fixed by inserting an "&& defined(_MSC_VER)" clause, but the whole block is entirely useless (it comments out the include of stdint) and users pull in xen/types.h transitively. Delete the whole block, and include xen/types.h to make it standalone. No functional change. Signed-off-by: Andrew Cooper Acked-by: Jan Beulich --- xen/include/crypto/vmac.h | 25 ++----------------------- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/xen/include/crypto/vmac.h b/xen/include/crypto/vmac.h index 7574c4a3f3..735d2760a5 100644 --- a/xen/include/crypto/vmac.h +++ b/xen/include/crypto/vmac.h @@ -1,6 +1,8 @@ #ifndef HEADER_VMAC_H #define HEADER_VMAC_H +#include + /* -------------------------------------------------------------------------- * VMAC and VHASH Implementation by Ted Krovetz (tdk@acm.org) and Wei Dai. * This implementation is herby placed in the public domain. @@ -35,29 +37,6 @@ #define hz (400e6) mips */ -/* -------------------------------------------------------------------------- - * This implementation uses uint32_t and uint64_t as names for unsigned 32- - * and 64-bit integer types. These are defined in C99 stdint.h. The - * following may need adaptation if you are not running a C99 or - * Microsoft C environment. - * ----------------------------------------------------------------------- */ -#define VMAC_USE_STDINT 1 /* Set to zero if system has no stdint.h */ - -#if VMAC_USE_STDINT && !_MSC_VER /* Try stdint.h if non-Microsoft */ -#ifdef __cplusplus -#define __STDC_CONSTANT_MACROS -#endif -//#include -#elif (_MSC_VER) /* Microsoft C does not have stdint.h */ -typedef unsigned __int32 uint32_t; -typedef unsigned __int64 uint64_t; -#define UINT64_C(v) v ## UI64 -#else /* Guess sensibly - may need adaptation */ -typedef unsigned int uint32_t; -typedef unsigned long long uint64_t; -#define UINT64_C(v) v ## ULL -#endif - /* -------------------------------------------------------------------------- * This implementation supports two free AES implementations: OpenSSL's and * Paulo Barreto's. To use OpenSSL's, you will need to include the OpenSSL