From 2da5f616e056eb17fee7eecfa68cd29ae4e4ae1f Mon Sep 17 00:00:00 2001 From: Alejandro Vallejo Date: Wed, 16 Jul 2025 17:35:03 +0200 Subject: [PATCH] dom0less: Fix LLC coloring when mixing colored and non-colored domains llc_colors_str being outside the main loop makes domains without explicit coloring inherit the colors of the last colored domain parsed. Move it inside so that's no longer the case. Fixes: 5948dc16759c("xen/arm: add support for cache coloring...") Signed-off-by: Alejandro Vallejo Reviewed-by: Denis Mukhin Reviewed-by: Stefano Stabellini --- xen/common/device-tree/dom0less-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/device-tree/dom0less-build.c b/xen/common/device-tree/dom0less-build.c index 221b875a2f..87828d4d9d 100644 --- a/xen/common/device-tree/dom0less-build.c +++ b/xen/common/device-tree/dom0less-build.c @@ -829,11 +829,11 @@ void __init create_domUs(void) bool iommu = false; const struct dt_device_node *cpupool_node, *chosen = dt_find_node_by_path("/chosen"); - const char *llc_colors_str = NULL; BUG_ON(chosen == NULL); dt_for_each_child_node(chosen, node) { + const char *llc_colors_str = NULL; struct domain *d; struct xen_domctl_createdomain d_cfg = {0}; unsigned int flags = 0U;