diff --git a/xen/drivers/passthrough/amd/iommu_init.c b/xen/drivers/passthrough/amd/iommu_init.c index bb5a3e57c9..df7dded939 100644 --- a/xen/drivers/passthrough/amd/iommu_init.c +++ b/xen/drivers/passthrough/amd/iommu_init.c @@ -1103,6 +1103,15 @@ static void __init amd_iommu_init_cleanup(void) { struct amd_iommu *iommu, *next; + /* free interrupt remapping table */ + if ( amd_iommu_perdev_intremap ) + iterate_ivrs_entries(amd_iommu_free_intremap_table); + else if ( shared_intremap_table ) + amd_iommu_free_intremap_table(list_first_entry(&amd_iommu_head, + struct amd_iommu, + list), + NULL); + /* free amd iommu list */ list_for_each_entry_safe ( iommu, next, &amd_iommu_head, list ) { @@ -1125,9 +1134,6 @@ static void __init amd_iommu_init_cleanup(void) xfree(iommu); } - /* free interrupt remapping table */ - iterate_ivrs_entries(amd_iommu_free_intremap_table); - /* free device table */ deallocate_device_table(&device_table); diff --git a/xen/drivers/passthrough/amd/iommu_intr.c b/xen/drivers/passthrough/amd/iommu_intr.c index 0164ceac3b..4f8a56f9c5 100644 --- a/xen/drivers/passthrough/amd/iommu_intr.c +++ b/xen/drivers/passthrough/amd/iommu_intr.c @@ -792,14 +792,23 @@ void amd_iommu_read_msi_from_ire( int __init amd_iommu_free_intremap_table( const struct amd_iommu *iommu, struct ivrs_mappings *ivrs_mapping) { - void *tb = ivrs_mapping->intremap_table; + void **tblp; - XFREE(ivrs_mapping->intremap_inuse); - - if ( tb ) + if ( ivrs_mapping ) { - __free_amd_iommu_tables(tb, intremap_table_order(iommu)); - ivrs_mapping->intremap_table = NULL; + XFREE(ivrs_mapping->intremap_inuse); + tblp = &ivrs_mapping->intremap_table; + } + else + { + XFREE(shared_intremap_inuse); + tblp = &shared_intremap_table; + } + + if ( *tblp ) + { + __free_amd_iommu_tables(*tblp, intremap_table_order(iommu)); + *tblp = NULL; } return 0;