mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 18:21:39 +01:00
mm.h: fix BUG_ON() condition in put_page_alloc_ref()
The BUG_ON() was misplaced when this function was introduced in commit
ec83f825 "mm.h: add helper function to test-and-clear _PGC_allocated".
It will fire incorrectly if _PGC_allocated is already clear on entry. Thus
it should be moved after the if statement.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
1 parent
ec83f82562
commit
44a887d021
1 file changed
+3
-1
@@ -667,9 +667,11 @@ static inline void put_page_alloc_ref(struct page_info *page)
|
||||
* the caller holding an additional reference. I.e. the allocation
|
||||
* reference must never be the last reference held.
|
||||
*/
|
||||
BUG_ON((page->count_info & PGC_count_mask) <= 1);
|
||||
if ( test_and_clear_bit(_PGC_allocated, &page->count_info) )
|
||||
{
|
||||
BUG_ON((page->count_info & PGC_count_mask) <= 1);
|
||||
put_page(page);
|
||||
}
|
||||
}
|
||||
|
||||
#endif /* __XEN_MM_H__ */
|
||||