xend: fix ballooning bug

c/s 18960 introduced a bug when xend balloons memory. The function
balloon.free requires a reference to a XendDomainInfo object, which is
missing in one call of this function. Attached patch fixes this. Also
replaced the variable name "self" in the (classless) function with
something more descriptive.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>
Reported-by: Maik Hentsche <maik.hentsche@amd.com>
This commit is contained in:
Keir Fraser committed 2009-01-13 15:29:06 +00:00
1 parent 542f7a560f
commit 47cee35ef0
2 files changed
+3 -3

No files matched your search

+1 -1
View File
@@ -1199,7 +1199,7 @@ class XendDomainInfo:
if self.domid >= 0:
if target > memory_cur:
balloon.free( (target-memory_cur)*1024 )
balloon.free((target - memory_cur) * 1024, self)
self.storeVm("memory", target)
self.storeDom("memory/target", target << 10)
xc.domain_set_target_mem(self.domid,
+2 -2
View File
@@ -67,7 +67,7 @@ def get_dom0_target_alloc():
raise VmError('Failed to query target memory allocation of dom0.')
return kb
def free(need_mem ,self):
def free(need_mem, dominfo):
"""Balloon out memory from the privileged domain so that there is the
specified required amount (in KiB) free.
"""
@@ -130,7 +130,7 @@ def free(need_mem ,self):
if physinfo['nr_nodes'] > 1 and retries == 0:
oldnode = -1
waitscrub = 1
vcpus = self.info['cpus'][0]
vcpus = dominfo.info['cpus'][0]
for vcpu in vcpus:
nodenum = 0
for node in physinfo['node_to_cpu']:
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.