mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 18:50:05 +01:00
Don't canonicalise the resource inside res_security_check if security is off.
This had broken use of relative paths to refer to ISOs etc. Signed-off-by: Ewan Mellor <ewan@xensource.com>
This commit is contained in:
1 parent
dba11d1f26
commit
535e80fa87
1 file changed
+5
-3
@@ -637,11 +637,11 @@ def res_security_check(resource, domain_label):
|
||||
"""
|
||||
rtnval = 1
|
||||
|
||||
#build canonical resource name
|
||||
resource = unify_resname(resource)
|
||||
|
||||
# if security is on, ask the hypervisor for a decision
|
||||
if on():
|
||||
#build canonical resource name
|
||||
resource = unify_resname(resource)
|
||||
|
||||
(label, ssidref, policy) = get_res_security_details(resource)
|
||||
domac = ['access_control']
|
||||
domac.append(['policy', active_policy])
|
||||
@@ -660,6 +660,8 @@ def res_security_check(resource, domain_label):
|
||||
|
||||
# security is off, make sure resource isn't labeled
|
||||
else:
|
||||
# Note, we can't canonicalise the resource here, because people using
|
||||
# xm without ACM are free to use relative paths.
|
||||
(label, policy) = get_res_label(resource)
|
||||
if policy != 'NULL':
|
||||
raise ACMError("Security is off, but '"+resource+"' is labeled")
|
||||
|
||||