From 550ee7c198010c297d74b69e07d95a26358eadbd Mon Sep 17 00:00:00 2001 From: Roger Pau Monne Date: Fri, 20 Mar 2026 10:17:15 +0100 Subject: [PATCH] xen/uart: report an error if the device type is not supported MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When using key pairs for the uart configuration (com1 and com2 command line options), report an error if the passed device= is not recognized instead of silently ignoring it. Signed-off-by: Roger Pau Monné Reviewed-by: Andrew Cooper --- xen/drivers/char/ns16550.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index df7fff7f81..d384f1c69d 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -1674,6 +1674,8 @@ static bool __init parse_namevalue_pairs(char *str, struct ns16550 *uart) pci_uart_config(uart, 0, uart - ns16550_com); dev_set = true; } + else + PARSE_ERR_RET("Unknown device type %s\n", param_value); break; case port_bdf: