python: Adjust xc_physinfo wrapper for updated virt_caps bits

Commit f089fddd94 "xen: report PV capability in sysctl and use it in
toolstack" changed meaning of virt_caps bit 1 - previously it was
"directio", but was changed to "pv" and "directio" was moved to bit 2.
Adjust python wrapper to use #defines for the bits values, and add
reporting of both "pv_directio" and "hvm_directio".

Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
This commit is contained in:
Marek Marczykowski-Górecki authored and Wei Liu committed 2019-05-13 11:28:27 +01:00
1 parent 31d72a0fd4
commit 569e848a48
1 file changed
+13 -3
+13 -3
View File
@@ -972,11 +972,17 @@ static PyObject *pyxc_physinfo(XcObject *self)
xc_physinfo_t pinfo;
char cpu_cap[128], virt_caps[128], *p;
int i;
const char *virtcap_names[] = { "hvm", "hvm_directio" };
const char *virtcap_names[] = { "hvm", "pv" };
const unsigned virtcaps_bits[] = { XEN_SYSCTL_PHYSCAP_hvm,
XEN_SYSCTL_PHYSCAP_pv };
if ( xc_physinfo(self->xc_handle, &pinfo) != 0 )
return pyxc_error_to_exception(self->xc_handle);
/*
* Keep in sync with tools/xl/xl_info.c:output_xeninfo
* and struct xen_sysctl_physinfo (especially bit fields).
*/
p = cpu_cap;
*p = '\0';
for ( i = 0; i < sizeof(pinfo.hw_cap)/4; i++ )
@@ -985,9 +991,13 @@ static PyObject *pyxc_physinfo(XcObject *self)
p = virt_caps;
*p = '\0';
for ( i = 0; i < 2; i++ )
if ( (pinfo.capabilities >> i) & 1 )
for ( i = 0; i < ARRAY_SIZE(virtcaps_bits); i++ )
if ( pinfo.capabilities & virtcaps_bits[i] )
p += sprintf(p, "%s ", virtcap_names[i]);
if ( pinfo.capabilities & XEN_SYSCTL_PHYSCAP_directio )
for ( i = 0; i < ARRAY_SIZE(virtcaps_bits); i++ )
if ( pinfo.capabilities & virtcaps_bits[i] )
p += sprintf(p, "%s_directio ", virtcap_names[i]);
if ( p != virt_caps )
*(p-1) = '\0';
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.