From 57c648a35bbc702b9740828d04b68ee1b3eb8e29 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 28 Sep 2026 14:26:05 +0200 Subject: [PATCH] vPCI: drop bogus locking assertion MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit msix_find() is a local helper, with all callers explicitly acquiring the per-domain PCI r/w lock. The checking, which should never have included the alternative of holding the global PCI devices lock, therefore is pretty much pointless. Signed-off-by: Jan Beulich Acked-by: Roger Pau Monné --- xen/drivers/vpci/msix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/drivers/vpci/msix.c b/xen/drivers/vpci/msix.c index 1f93a862da..5b01859acf 100644 --- a/xen/drivers/vpci/msix.c +++ b/xen/drivers/vpci/msix.c @@ -158,8 +158,6 @@ static struct vpci_msix *msix_find(const struct domain *d, unsigned long addr) { struct vpci_msix *msix; - ASSERT_PDEV_LIST_IS_READ_LOCKED(d); - list_for_each_entry ( msix, &d->arch.hvm.msix_tables, next ) { const struct vpci_bar *bars = msix->pdev->vpci->header.bars;