From 5bbd39daee372e3b12eec50169b54870cfec9e03 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Thu, 26 Mar 2015 08:20:11 +0100 Subject: [PATCH] complete conversion set_bit() -> __cpumask_set_cpu() by 4aaca0e9cd While converting to __cpumask_set_cpu() was correct, the first argument passed should have been corrected to be "cpu" instead of "nr" at once. The wrong construct results in problems on systems with relatively few CPUs. Reported-by: Sander Eikelenboom Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Acked-by: Ian Campbell master commit: 5dbdf33c57e3c95125b92f86d847ed8432e28f1c master date: 2015-02-27 16:09:27 +0100 --- xen/common/softirq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/common/softirq.c b/xen/common/softirq.c index 22e417ada7..33d5d8627e 100644 --- a/xen/common/softirq.c +++ b/xen/common/softirq.c @@ -106,7 +106,7 @@ void cpu_raise_softirq(unsigned int cpu, unsigned int nr) if ( !per_cpu(batching, this_cpu) || in_irq() ) smp_send_event_check_cpu(cpu); else - set_bit(nr, &per_cpu(batch_mask, this_cpu)); + cpumask_set_cpu(cpu, &per_cpu(batch_mask, this_cpu)); } void cpu_raise_softirq_batch_begin(void)