From 70c47ec5d65fa985ef7becd74b2d7b6d744b4c97 Mon Sep 17 00:00:00 2001 From: Andrew Cooper Date: Fri, 20 Feb 2026 15:46:26 +0000 Subject: [PATCH] xen: Adjust break/fallthrough statements sh_destroy_shadow() has a spelling of fallthrough which doesn't match the permitted pattern. Convert it to a real fallthrough (psedo)keyword. Elsewhere, insert breaks at the end of the default statements. No functional change. Signed-off-by: Andrew Cooper Reviewed-by: Nicola Vetrini Reviewed-by: Michal Orzel --- xen/arch/arm/pci/pci-access.c | 2 ++ xen/arch/arm/pci/pci-designware.c | 2 ++ xen/arch/arm/tee/optee.c | 1 + xen/arch/x86/mm/shadow/common.c | 2 +- 4 files changed, 6 insertions(+), 1 deletion(-) diff --git a/xen/arch/arm/pci/pci-access.c b/xen/arch/arm/pci/pci-access.c index c0533c00c9..2b23d552bb 100644 --- a/xen/arch/arm/pci/pci-access.c +++ b/xen/arch/arm/pci/pci-access.c @@ -63,6 +63,7 @@ int pci_generic_config_read(struct pci_host_bridge *bridge, pci_sbdf_t sbdf, break; default: ASSERT_UNREACHABLE(); + break; } return 0; @@ -89,6 +90,7 @@ int pci_generic_config_write(struct pci_host_bridge *bridge, pci_sbdf_t sbdf, break; default: ASSERT_UNREACHABLE(); + break; } return 0; diff --git a/xen/arch/arm/pci/pci-designware.c b/xen/arch/arm/pci/pci-designware.c index 6b85213f63..902da19e8c 100644 --- a/xen/arch/arm/pci/pci-designware.c +++ b/xen/arch/arm/pci/pci-designware.c @@ -48,6 +48,7 @@ static int dw_pcie_read(void __iomem *addr, unsigned int len, uint32_t *val) break; default: ASSERT_UNREACHABLE(); + break; } return 0; @@ -71,6 +72,7 @@ static int dw_pcie_write(void __iomem *addr, unsigned int len, uint32_t val) break; default: ASSERT_UNREACHABLE(); + break; } return 0; diff --git a/xen/arch/arm/tee/optee.c b/xen/arch/arm/tee/optee.c index 699e8d5368..f719d9d767 100644 --- a/xen/arch/arm/tee/optee.c +++ b/xen/arch/arm/tee/optee.c @@ -1206,6 +1206,7 @@ static void do_call_with_arg(struct optee_domain *ctx, default: /* Free any temporary shared buffers */ free_shm_buffers(ctx, call->xen_arg); + break; } put_std_call(ctx, call); diff --git a/xen/arch/x86/mm/shadow/common.c b/xen/arch/x86/mm/shadow/common.c index e07ba6d5a7..dd2d04d049 100644 --- a/xen/arch/x86/mm/shadow/common.c +++ b/xen/arch/x86/mm/shadow/common.c @@ -1213,7 +1213,7 @@ void sh_destroy_shadow(struct domain *d, mfn_t smfn) #ifdef CONFIG_PV32 case SH_type_l2h_64_shadow: ASSERT(is_pv_32bit_domain(d)); - /* Fall through... */ + fallthrough; #endif case SH_type_l2_64_shadow: SHADOW_INTERNAL_NAME(sh_destroy_l2_shadow, 4)(d, smfn);