From 70f5a875becc9444a959830b10a361982c31a366 Mon Sep 17 00:00:00 2001 From: Michal Orzel Date: Wed, 8 Jan 2025 08:57:19 +0100 Subject: [PATCH] xen/arm64: Drop relocate_and_switch_ttbr() stub In the original patch e7a80636f16e ("xen/arm: add cache coloring support for Xen image"), the stub was added under wrong assumption that DCE won't remove the function call if it's not static. This assumption is incorrect as we already rely on DCE for cases like this one. Therefore drop the stub, that otherwise would be a place potentially prone to errors in the future. Suggested-by: Julien Grall Signed-off-by: Michal Orzel Reviewed-by: Luca Fancellu Release-Acked-By: Oleksii Kurochko Reviewed-by: Bertrand Marquis --- xen/arch/arm/arm64/mmu/mm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/xen/arch/arm/arm64/mmu/mm.c b/xen/arch/arm/arm64/mmu/mm.c index 26361c4fe4..c1efa1348a 100644 --- a/xen/arch/arm/arm64/mmu/mm.c +++ b/xen/arch/arm/arm64/mmu/mm.c @@ -171,8 +171,6 @@ void __init relocate_and_switch_ttbr(uint64_t ttbr) */ update_identity_mapping(false); } -#else -void __init relocate_and_switch_ttbr(uint64_t ttbr) {} #endif void __init switch_ttbr(uint64_t ttbr)