libxc: panic when trying to create a PVH guest without kernel support

Previously when trying to boot a PV capable but not PVH capable kernel
inside of a PVH container xc_dom_guest_type would succeed and return a
PV guest type, which would lead to failures later on in the build
process.

Instead provide a clear error message when trying to create a PVH
guest using a kernel that doesn't support PVH.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
This commit is contained in:
Roger Pau Monne authored and Ian Jackson committed 2017-10-09 15:43:35 +01:00
1 parent 265dabbc6f
commit 96edb111dd
1 file changed
+7
+7
View File
@@ -59,6 +59,13 @@ static char *xc_dom_guest_type(struct xc_dom_image *dom,
if ( dom->container_type == XC_DOM_HVM_CONTAINER &&
dom->parms.phys_entry != UNSET_ADDR32 )
return "hvm-3.0-x86_32";
if ( dom->container_type == XC_DOM_HVM_CONTAINER )
{
xc_dom_panic(dom->xch, XC_INVALID_KERNEL,
"%s: image not capable of booting inside a HVM container",
__FUNCTION__);
return "xen-3.0-unknown";
}
switch ( machine )
{
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.