VT-d: use ioremap()

There's no point in using the fixmap here, and it gets iommu_alloc()
in line with iommu_free(), which was already using iounmap() (thus
crashing if actually used).

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
This commit is contained in:
Jan Beulich committed 2013-07-15 14:21:03 +02:00
1 parent 8bfaa2c23f
commit 99321e0e6c
4 files changed
+4 -13

No files matched your search

-2
View File
@@ -127,8 +127,6 @@ do { \
} \
} while (0)
void *map_to_nocache_virt(int nr_iommus, u64 maddr);
int vtd_hw_check(void);
void disable_pmr(struct iommu *iommu);
int is_usb_device(u16 seg, u8 bus, u8 devfn);
+4 -3
View File
@@ -1142,15 +1142,16 @@ int __init iommu_alloc(struct acpi_drhd_unit *drhd)
return -ENOMEM;
}
iommu->intel->drhd = drhd;
drhd->iommu = iommu;
iommu->reg = map_to_nocache_virt(nr_iommus, drhd->address);
iommu->reg = ioremap(drhd->address, PAGE_SIZE);
if ( !iommu->reg )
return -ENOMEM;
iommu->index = nr_iommus++;
iommu->cap = dmar_readq(iommu->reg, DMAR_CAP_REG);
iommu->ecap = dmar_readq(iommu->reg, DMAR_ECAP_REG);
drhd->iommu = iommu;
if ( iommu_verbose )
{
dprintk(VTDPREFIX,
-6
View File
@@ -64,12 +64,6 @@ void flush_all_cache()
wbinvd();
}
void *__init map_to_nocache_virt(int nr_iommus, u64 maddr)
{
set_fixmap_nocache(FIX_IOMMU_REGS_BASE_0 + nr_iommus, maddr);
return (void *)fix_to_virt(FIX_IOMMU_REGS_BASE_0 + nr_iommus);
}
static int _hvm_dpci_isairq_eoi(struct domain *d,
struct hvm_pirq_dpci *pirq_dpci, void *arg)
{
-2
View File
@@ -60,8 +60,6 @@ enum fixed_addresses {
FIX_KEXEC_BASE_0,
FIX_KEXEC_BASE_END = FIX_KEXEC_BASE_0 \
+ ((KEXEC_XEN_NO_PAGES >> 1) * KEXEC_IMAGE_NR) - 1,
FIX_IOMMU_REGS_BASE_0,
FIX_IOMMU_REGS_END = FIX_IOMMU_REGS_BASE_0 + MAX_IOMMUS-1,
FIX_IOMMU_MMIO_BASE_0,
FIX_IOMMU_MMIO_END = FIX_IOMMU_MMIO_BASE_0 + IOMMU_PAGES -1,
FIX_TBOOT_SHARED_BASE,
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.