diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index f937c1d350..ab30e2e8cf 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -4026,7 +4026,7 @@ int gnttab_acquire_resource( struct grant_table *gt = d->grant_table; unsigned int i, final_frame; mfn_t tmp; - void **vaddrs; + void **vaddrs = NULL; int rc = -EINVAL; if ( !nr_frames ) @@ -4055,6 +4055,17 @@ int gnttab_acquire_resource( break; } + /* + * Some older toolchains can't spot that vaddrs won't remain uninitialized + * on non-error paths, and hence it needs setting to NULL at the top of the + * function. Leave some runtime safety. + */ + if ( !vaddrs ) + { + ASSERT_UNREACHABLE(); + rc = -ENODATA; + } + /* Any errors? Bad id, or from growing the table? */ if ( rc ) goto out;