From ab2d455dcd06d19b4f6755bf406ee7302e879c02 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Fri, 27 May 2016 14:41:56 +0200 Subject: [PATCH] x86/PoD: skip eager reclaim when possible Reclaiming pages is pointless when the cache can already satisfy all outstanding PoD entries, and doing reclaims in that case can be very harmful to performance when that memory gets used by the guest, but only to store zeroes there. Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper Release-acked-by: Wei Liu Reviewed-by: George Dunlap master commit: 556c69f4efb09dd06e6bce4cbb0455287f19d02e master date: 2016-05-12 18:02:21 +0200 --- xen/arch/x86/mm/p2m-pod.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/p2m-pod.c b/xen/arch/x86/mm/p2m-pod.c index 0091802777..a08cfef289 100644 --- a/xen/arch/x86/mm/p2m-pod.c +++ b/xen/arch/x86/mm/p2m-pod.c @@ -1003,7 +1003,6 @@ static void pod_eager_record(struct p2m_domain *p2m, { struct pod_mrp_list *mrp = &p2m->pod.mrp; - ASSERT(mrp->list[mrp->idx] == INVALID_GFN); ASSERT(gfn != INVALID_GFN); mrp->list[mrp->idx++] = @@ -1051,7 +1050,9 @@ p2m_pod_demand_populate(struct p2m_domain *p2m, unsigned long gfn, return 0; } - pod_eager_reclaim(p2m); + /* Only reclaim if we're in actual need of more cache. */ + if ( p2m->pod.entry_count > p2m->pod.count ) + pod_eager_reclaim(p2m); /* Only sweep if we're actually out of memory. Doing anything else * causes unnecessary time and fragmentation of superpages in the p2m. */