mirror of
https://github.com/xen-project/xen.git
synced 2026-10-30 03:00:05 +01:00
x86/shstk: Activate Supervisor Shadow Stacks
With all other plumbing in place, activate shadow stacks when possible. Note that CET shares the similar problems to SMEP/SMAP with Ring1 being supervisor to the processor, and that the layout of the shadow stack differs between an IRET to Ring 1 and Ring 3. Therefore, we disable PV32 when CET is enabled. Compatibility can be maintained if necessary via PV-Shim. The BSP needs to wait until alternatives have run (to avoid interaction with CR0.WP), and after the first reset_stack_and_jump() to avoid having a pristine shadow stack interact in problematic ways with an in-use regular stack. Activate shadow stack in reinit_bsp_stack(). APs have all infrastructure set up by the booting CPU, so enable shadow stacks before entering C. Adjust the logic to call start_secondary rather than jump to it, so stack traces make more sense. The crash path needs to turn CET off to avoid interfering with the crash kernel's environment. Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com> Reviewed-by: Jan Beulich <jbeulich@suse.com>
This commit is contained in:
1 parent
633ecc4a7c
commit
b60ab42db2
6 files changed
+87
-1
No files matched your search
@@ -287,6 +287,10 @@ call/jmp COP/JOP) attacks.
|
||||
`cet=no-shstk` will cause Xen not to use Shadow Stacks even when support
|
||||
is available in hardware.
|
||||
|
||||
Shadow Stacks are incompatible with 32bit PV guests. This option will
|
||||
override the `pv=32` boolean to false. Backwards compatibility can be
|
||||
maintained with the `pv-shim` mechanism.
|
||||
|
||||
### clocksource (x86)
|
||||
> `= pit | hpet | acpi | tsc`
|
||||
|
||||
@@ -1726,6 +1730,10 @@ Controls for aspects of PV guest support.
|
||||
* The `32` boolean controls whether 32bit PV guests can be created. It
|
||||
defaults to `true`, and is ignored when `CONFIG_PV32` is compiled out.
|
||||
|
||||
32bit PV guests are incompatible with CET Shadow Stacks. If Xen is using
|
||||
shadow stacks, this option will be overridden to `false`. Backwards
|
||||
compatibility can be maintained with the `pv-shim` mechanism.
|
||||
|
||||
### pv-linear-pt (x86)
|
||||
> `= <boolean>`
|
||||
|
||||
|
||||