x86/HVM: correct segment register loading during task switch

Instead of #NP, #SS needs to be raised for a non-present %ss
descriptor.

Don't lose the low two selector bits on null selector loads.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Jan Beulich committed 2016-09-26 17:27:34 +02:00
1 parent dcfd9a5ead
commit bdb860d01c
1 file changed
+3 -1
+3 -1
View File
@@ -2723,6 +2723,7 @@ static int hvm_load_segment_selector(
if ( (seg == x86_seg_cs) || (seg == x86_seg_ss) )
goto fail;
memset(&segr, 0, sizeof(segr));
segr.sel = sel;
hvm_set_segment_register(v, seg, &segr);
return 0;
}
@@ -2749,7 +2750,8 @@ static int hvm_load_segment_selector(
/* Segment present in memory? */
if ( !(desc.b & _SEGMENT_P) )
{
fault_type = TRAP_no_segment;
fault_type = (seg != x86_seg_ss) ? TRAP_no_segment
: TRAP_stack_error;
goto unmap_and_fail;
}
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.