From bea8b179138b5c1f99c9ab953a64627118aaf932 Mon Sep 17 00:00:00 2001 From: Teddy Astie Date: Mon, 1 Dec 2025 10:12:58 +0100 Subject: [PATCH] x86/ept: Drop shadow mode check in ept_sync_domain() This function can only be reached from EPT-related code which is inherently HAP. Thus it is not useful to check for shadow_paging (or lack of HAP) there. Moreover, it is an error to call this function in the non-EPT cases. Not a functional change. Signed-off-by: Teddy Astie Reviewed-by: Jan Beulich --- xen/arch/x86/mm/p2m-ept.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/xen/arch/x86/mm/p2m-ept.c b/xen/arch/x86/mm/p2m-ept.c index ce4ef632ae..dfdbfa0afe 100644 --- a/xen/arch/x86/mm/p2m-ept.c +++ b/xen/arch/x86/mm/p2m-ept.c @@ -1268,9 +1268,10 @@ static void ept_sync_domain_mask(struct p2m_domain *p2m, const cpumask_t *mask) void ept_sync_domain(struct p2m_domain *p2m) { struct domain *d = p2m->domain; + ASSERT(hap_enabled(d)); - /* Only if using EPT and this domain has some VCPUs to dirty. */ - if ( paging_mode_shadow(d) || !d->vcpu || !d->vcpu[0] ) + /* Only if this domain has some VCPUs to dirty. */ + if ( !d->vcpu || !d->vcpu[0] ) return; ept_sync_domain_prepare(p2m);