From c482d1f59fc723d5b0aca3b288ca2f6007cd00a4 Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Mon, 24 Nov 2025 11:28:47 +0100 Subject: [PATCH] x86emul/test: correct compiler checking and avoid it when merely cleaning The error messages that the compiler may emit can be confusing. The check was also the wrong way round in case multiple make targets are specified: We want to do the check whenever targets other than the running and cleaning ones are specified. Fixes: 05f4cc219235 ("x86emul: suppress default test harness build with incapable compiler") Fixes: d5997399b7ad ("x86emul: suppress "not built" warning for test harness'es run targets") Signed-off-by: Jan Beulich Acked-by: Andrew Cooper --- tools/tests/x86_emulator/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/tests/x86_emulator/Makefile b/tools/tests/x86_emulator/Makefile index fefa29a06c..3e02580a35 100644 --- a/tools/tests/x86_emulator/Makefile +++ b/tools/tests/x86_emulator/Makefile @@ -98,7 +98,7 @@ avx512bw-opmask-vecs := 4 8 # partially even with older compilers. TARGET-y := $(TARGET) -ifeq ($(filter run%,$(MAKECMDGOALS)),) +ifneq ($(filter-out run% clean% distclean,$(MAKECMDGOALS)),) define isa-check-cc TARGET-$(shell echo 'int i;' | $(CC) -x c -c -o /dev/null -m$(1) - || echo y) :=