diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c index dc92dca4ec..ebabc10763 100644 --- a/xen/arch/x86/hvm/hvm.c +++ b/xen/arch/x86/hvm/hvm.c @@ -453,14 +453,17 @@ static void hvm_io_assist(struct hvm_ioreq_vcpu *sv, uint64_t data) static bool_t hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) { + unsigned int prev_state = STATE_IOREQ_NONE; + while ( sv->pending ) { unsigned int state = p->state; - rmb(); - switch ( state ) + smp_rmb(); + + recheck: + if ( unlikely(state == STATE_IOREQ_NONE) ) { - case STATE_IOREQ_NONE: /* * The only reason we should see this case is when an * emulator is dying and it races with an I/O being @@ -468,14 +471,30 @@ static bool_t hvm_wait_for_io(struct hvm_ioreq_vcpu *sv, ioreq_t *p) */ hvm_io_assist(sv, ~0ul); break; + } + + if ( unlikely(state < prev_state) ) + { + gdprintk(XENLOG_ERR, "Weird HVM ioreq state transition %u -> %u\n", + prev_state, state); + sv->pending = 0; + domain_crash(sv->vcpu->domain); + return 0; /* bail */ + } + + switch ( prev_state = state ) + { case STATE_IORESP_READY: /* IORESP_READY -> NONE */ p->state = STATE_IOREQ_NONE; hvm_io_assist(sv, p->data); break; case STATE_IOREQ_READY: /* IOREQ_{READY,INPROCESS} -> IORESP_READY */ case STATE_IOREQ_INPROCESS: - wait_on_xen_event_channel(sv->ioreq_evtchn, p->state != state); - break; + wait_on_xen_event_channel(sv->ioreq_evtchn, + ({ state = p->state; + smp_rmb(); + state != prev_state; })); + goto recheck; default: gdprintk(XENLOG_ERR, "Weird HVM iorequest state %u\n", state); sv->pending = 0;