xen-project/xen
1
0 Fork 0
mirror of https://github.com/xen-project/xen.git synced 2026-10-28 02:01:24 +01:00
Code Issues Activity

x86/boot: add start and size fields to struct boot_module

Browse Source 
Introduce the start and size fields to struct boot_module and assigns
their value during boot_info construction. All uses of module_t to get
the address and size of a module are replaced with start and size.

The EFI entry point is a special case, as the EFI file loading boot
service may load a file beyond the 4G barrier. As a result, to make the
address fit in the 32bit integer used by the MB1 module_t structure, the
frame number is stored in mod_start and size in mod_end. Until the EFI
entry point is enlightened to work with boot_info and boot_module,
multiboot_fill_boot_info will handle the alternate values in mod_start
and mod_end when EFI is detected.

A result of the switch to start/size removes all uses of the mod field
in struct boot_modules, along with the uses of bootstrap_map() and
release_module() functions. With all usage gone, they all are dropped
here.

Signed-off-by: Daniel P. Smith <dpsmith@apertussolutions.com>
Reviewed-by: Jason Andryuk <jason.andryuk@amd.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
Daniel P. Smith authored and Andrew Cooper committed 2024-11-19 19:53:51 +00:00
1 parent 6308301208
commit cd7cc5320b
7 files changed
+60 -67
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

xen/arch/x86/cpu/microcode/core.c
+4 -4
View File
@@ -688,8 +688,8 @@ static int __init cf_check microcode_init_cache(void)
/* early_microcode_load() didn't leave us any work to do. */
return 0;
size = bi->mods[early_mod_idx].mod->mod_end;
data = __mfn_to_virt(bi->mods[early_mod_idx].mod->mod_start);
size = bi->mods[early_mod_idx].size;
data = __va(bi->mods[early_mod_idx].start);
/*
* If opt_scan is set, we're looking for a CPIO archive rather than a raw
@@ -765,7 +765,7 @@ static int __init early_microcode_load(struct boot_info *bi)
bm->type != BOOTMOD_RAMDISK )
continue;
size = bm->mod->mod_end;
size = bm->size;
data = bootstrap_map_bm(bm);
if ( !data )
{
@@ -819,7 +819,7 @@ static int __init early_microcode_load(struct boot_info *bi)
}
bi->mods[idx].type = BOOTMOD_MICROCODE;
size = bi->mods[idx].mod->mod_end;
size = bi->mods[idx].size;
data = bootstrap_map_bm(&bi->mods[idx]);
if ( !data )
{
xen/arch/x86/hvm/dom0_build.c
+3 -3
View File
@@ -649,8 +649,8 @@ static int __init pvh_load_kernel(
{
void *image_base = bootstrap_map_bm(image);
void *image_start = image_base + image->headroom;
unsigned long image_len = image->mod->mod_end;
unsigned long initrd_len = initrd ? initrd->mod->mod_end : 0;
unsigned long image_len = image->size;
unsigned long initrd_len = initrd ? initrd->size : 0;
const char *cmdline = image->cmdline_pa ? __va(image->cmdline_pa) : NULL;
struct elf_binary elf;
struct elf_dom_parms parms;
@@ -726,7 +726,7 @@ static int __init pvh_load_kernel(
if ( initrd != NULL )
{
rc = hvm_copy_to_guest_phys(last_addr, mfn_to_virt(initrd->mod->mod_start),
rc = hvm_copy_to_guest_phys(last_addr, __va(initrd->start),
initrd_len, v);
if ( rc )
{
xen/arch/x86/include/asm/bootinfo.h
+3 -3
View File
@@ -26,9 +26,6 @@ enum bootmod_type {
};
struct boot_module {
/* Transitionary only */
module_t *mod;
enum bootmod_type type;
/*
@@ -62,6 +59,9 @@ struct boot_module {
unsigned long headroom;
paddr_t cmdline_pa;
paddr_t start;
size_t size;
};
/*
xen/arch/x86/include/asm/setup.h
-1
View File
@@ -38,7 +38,6 @@ void free_boot_modules(void);
struct boot_module;
void *bootstrap_map_bm(const struct boot_module *bm);
void *bootstrap_map(const module_t *mod);
void bootstrap_unmap(void);
void release_boot_module(struct boot_module *bm);
xen/arch/x86/pv/dom0_build.c
+7 -8
View File
@@ -422,14 +422,14 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
image = &bi->mods[i];
image_base = bootstrap_map_bm(image);
image_len = image->mod->mod_end;
image_len = image->size;
image_start = image_base + image->headroom;
i = first_boot_module_index(bi, BOOTMOD_RAMDISK);
if ( i < bi->nr_modules )
{
initrd = &bi->mods[i];
initrd_len = initrd->mod->mod_end;
initrd_len = initrd->size;
}
d->max_pages = ~0U;
@@ -631,7 +631,7 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
initrd_pfn = vinitrd_start ?
(vinitrd_start - v_start) >> PAGE_SHIFT :
domain_tot_pages(d);
initrd_mfn = initrd->mod->mod_start;
initrd_mfn = paddr_to_pfn(initrd->start);
mfn = initrd_mfn;
count = PFN_UP(initrd_len);
if ( d->arch.physaddr_bitsize &&
@@ -647,8 +647,7 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
free_domheap_pages(page, order);
page += 1UL << order;
}
memcpy(page_to_virt(page), mfn_to_virt(initrd->mod->mod_start),
initrd_len);
memcpy(page_to_virt(page), __va(initrd->start), initrd_len);
/*
* The initrd was copied but the initrd variable is reused in the
* calculations below. As to not leak the memory used for the
@@ -656,7 +655,7 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
*/
release_boot_module(initrd);
initrd_mfn = mfn_x(page_to_mfn(page));
initrd->mod->mod_start = initrd_mfn;
initrd->start = pfn_to_paddr(initrd_mfn);
}
else
{
@@ -683,7 +682,7 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
nr_pages - domain_tot_pages(d));
if ( initrd )
{
mpt_alloc = pfn_to_paddr(initrd->mod->mod_start);
mpt_alloc = initrd->start;
printk("\n Init. ramdisk: %"PRIpaddr"->%"PRIpaddr,
mpt_alloc, mpt_alloc + initrd_len);
}
@@ -911,7 +910,7 @@ static int __init dom0_construct(struct boot_info *bi, struct domain *d)
if ( pfn >= initrd_pfn )
{
if ( pfn < initrd_pfn + PFN_UP(initrd_len) )
mfn = initrd->mod->mod_start + (pfn - initrd_pfn);
mfn = paddr_to_pfn(initrd->start) + (pfn - initrd_pfn);
else
mfn -= PFN_UP(initrd_len);
}
xen/arch/x86/setup.c
+42 -47
View File
@@ -314,13 +314,29 @@ static struct boot_info *__init multiboot_fill_boot_info(
*/
for ( i = 0; i < MAX_NR_BOOTMODS && i < bi->nr_modules; i++ )
{
bi->mods[i].mod = &mods[i];
bi->mods[i].cmdline_pa = mods[i].string;
if ( efi_enabled(EFI_LOADER) )
{
/*
* The EFI loader gives us modules which are in frame/size. Switch
* to address/size.
*/
bi->mods[i].start = pfn_to_paddr(mods[i].mod_start);
bi->mods[i].size = mods[i].mod_end;
}
else
{
/*
* PVH and BIOS loaders give us modules which are start/end.
* Switch to address/size.
*/
bi->mods[i].start = mods[i].mod_start;
bi->mods[i].size = mods[i].mod_end - mods[i].mod_start;
}
}
/* Variable 'i' should be one entry past the last module. */
bi->mods[i].mod = &mods[bi->nr_modules];
bi->mods[i].type = BOOTMOD_XEN;
return bi;
@@ -336,8 +352,8 @@ unsigned long __init initial_images_nrpages(nodeid_t node)
for ( nr = i = 0; i < bi->nr_modules; ++i )
{
unsigned long start = bi->mods[i].mod->mod_start;
unsigned long end = start + PFN_UP(bi->mods[i].mod->mod_end);
unsigned long start = paddr_to_pfn(bi->mods[i].start);
unsigned long end = start + PFN_UP(bi->mods[i].size);
if ( end > node_start && node_end > start )
nr += min(node_end, end) - max(node_start, start);
@@ -348,12 +364,9 @@ unsigned long __init initial_images_nrpages(nodeid_t node)
void __init release_boot_module(struct boot_module *bm)
{
uint64_t start = pfn_to_paddr(bm->mod->mod_start);
uint64_t size = bm->mod->mod_end;
ASSERT(!bm->released);
init_domheap_pages(start, start + PAGE_ALIGN(size));
init_domheap_pages(bm->start, bm->start + PAGE_ALIGN(bm->size));
bm->released = true;
}
@@ -487,15 +500,9 @@ static void *__init bootstrap_map_addr(paddr_t start, paddr_t end)
return ret;
}
void *__init bootstrap_map(const module_t *mod)
{
return bootstrap_map_addr(pfn_to_paddr(mod->mod_start),
pfn_to_paddr(mod->mod_start) + mod->mod_end);
}
void *__init bootstrap_map_bm(const struct boot_module *bm)
{
return bootstrap_map(bm->mod);
return bootstrap_map_addr(bm->start, bm->start + bm->size);
}
void __init bootstrap_unmap(void)
@@ -673,8 +680,8 @@ static uint64_t __init consider_modules(
for ( i = 0; i < nr_mods ; ++i )
{
uint64_t start = pfn_to_paddr(mods[i].mod->mod_start);
uint64_t end = start + PAGE_ALIGN(mods[i].mod->mod_end);
uint64_t start = mods[i].start;
uint64_t end = start + PAGE_ALIGN(mods[i].size);
if ( i == this_mod )
continue;
@@ -1405,13 +1412,9 @@ void asmlinkage __init noreturn __start_xen(void)
set_kexec_crash_area_size((u64)nr_pages << PAGE_SHIFT);
kexec_reserve_area();
for ( i = 0; !efi_enabled(EFI_LOADER) && i < bi->nr_modules; i++ )
{
if ( bi->mods[i].mod->mod_start & (PAGE_SIZE - 1) )
for ( i = 0; i < bi->nr_modules; i++ )
if ( bi->mods[i].start & (PAGE_SIZE - 1) )
panic("Bootloader didn't honor module alignment request\n");
bi->mods[i].mod->mod_end -= bi->mods[i].mod->mod_start;
bi->mods[i].mod->mod_start >>= PAGE_SHIFT;
}
/*
* TODO: load ucode earlier once multiboot modules become accessible
@@ -1430,13 +1433,12 @@ void asmlinkage __init noreturn __start_xen(void)
* respective reserve_e820_ram() invocation below. No need to
* query efi_boot_mem_unused() here, though.
*/
xen->mod->mod_start = virt_to_mfn(_stext);
xen->mod->mod_end = __2M_rwdata_end - _stext;
xen->start = virt_to_maddr(_stext);
xen->size = __2M_rwdata_end - _stext;
}
bi->mods[0].headroom =
bzimage_headroom(bootstrap_map_bm(&bi->mods[0]),
bi->mods[0].mod->mod_end);
bzimage_headroom(bootstrap_map_bm(&bi->mods[0]), bi->mods[0].size);
bootstrap_unmap();
#ifndef highmem_start
@@ -1517,7 +1519,7 @@ void asmlinkage __init noreturn __start_xen(void)
for ( j = bi->nr_modules - 1; j >= 0; j-- )
{
struct boot_module *bm = &bi->mods[j];
unsigned long size = PAGE_ALIGN(bm->headroom + bm->mod->mod_end);
unsigned long size = PAGE_ALIGN(bm->headroom + bm->size);
if ( bm->relocated )
continue;
@@ -1529,14 +1531,11 @@ void asmlinkage __init noreturn __start_xen(void)
if ( highmem_start && end > highmem_start )
continue;
if ( s < end &&
(bm->headroom ||
((end - size) >> PAGE_SHIFT) > bm->mod->mod_start) )
if ( s < end && (bm->headroom || (end - size) > bm->start) )
{
move_memory(end - size + bm->headroom,
pfn_to_paddr(bm->mod->mod_start), bm->mod->mod_end);
bm->mod->mod_start = (end - size) >> PAGE_SHIFT;
bm->mod->mod_end += bm->headroom;
move_memory(end - size + bm->headroom, bm->start, bm->size);
bm->start = (end - size);
bm->size += bm->headroom;
bm->relocated = true;
}
}
@@ -1567,10 +1566,9 @@ void asmlinkage __init noreturn __start_xen(void)
panic("Not enough memory to relocate the dom0 kernel image\n");
for ( i = 0; i < bi->nr_modules; ++i )
{
const struct boot_module *bm = &bi->mods[i];
uint64_t s = pfn_to_paddr(bm->mod->mod_start);
uint64_t s = bi->mods[i].start, l = bi->mods[i].size;
reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(bm->mod->mod_end));
reserve_e820_ram(&boot_e820, s, s + PAGE_ALIGN(l));
}
if ( !xen_phys_start )
@@ -1648,8 +1646,7 @@ void asmlinkage __init noreturn __start_xen(void)
map_e = boot_e820.map[j].addr + boot_e820.map[j].size;
for ( j = 0; j < bi->nr_modules; ++j )
{
uint64_t end = pfn_to_paddr(bi->mods[j].mod->mod_start) +
bi->mods[j].mod->mod_end;
uint64_t end = bi->mods[j].start + bi->mods[j].size;
if ( map_e < end )
map_e = end;
@@ -1723,13 +1720,11 @@ void asmlinkage __init noreturn __start_xen(void)
for ( i = 0; i < bi->nr_modules; ++i )
{
const struct boot_module *bm = &bi->mods[i];
unsigned long s = bi->mods[i].start, l = bi->mods[i].size;
set_pdx_range(bm->mod->mod_start,
bm->mod->mod_start + PFN_UP(bm->mod->mod_end));
map_pages_to_xen((unsigned long)mfn_to_virt(bm->mod->mod_start),
_mfn(bm->mod->mod_start),
PFN_UP(bm->mod->mod_end), PAGE_HYPERVISOR);
set_pdx_range(paddr_to_pfn(s), paddr_to_pfn(s + l) + 1);
map_pages_to_xen((unsigned long)maddr_to_virt(s), maddr_to_mfn(s),
PFN_UP(l), PAGE_HYPERVISOR);
}
#ifdef CONFIG_KEXEC
xen/xsm/xsm_policy.c
+1 -1
View File
@@ -43,7 +43,7 @@ int __init xsm_multiboot_policy_init(
struct boot_module *bm = &bi->mods[i];
_policy_start = bootstrap_map_bm(bm);
_policy_len = bm->mod->mod_end;
_policy_len = bm->size;
if ( (xsm_magic_t)(*_policy_start) == XSM_MAGIC )
{
Reference in new issue
xen-project/xen
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.

The note is not visible to the blocked user.