ARM/dom0: Avoid using a variable length array in make_memory_node()

The reg[] array can have a maximum size of 8 in practice, so use the worst
case calculation rather than making it variable length.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Julien Grall <julien.grall@arm.com>
This commit is contained in:
Andrew Cooper authored and Julien Grall committed 2018-09-24 14:43:47 +01:00
1 parent 17bd254a50
commit cd8015b634
1 file changed
+3 -1
+3 -1
View File
@@ -539,9 +539,11 @@ static int __init make_memory_node(const struct domain *d,
int res, i;
int reg_size = addrcells + sizecells;
int nr_cells = reg_size*kinfo->mem.nr_banks;
__be32 reg[nr_cells];
__be32 reg[NR_MEM_BANKS * 4 /* Worst case addrcells + sizecells */];
__be32 *cells;
BUG_ON(nr_cells >= ARRAY_SIZE(reg));
dt_dprintk("Create memory node (reg size %d, nr cells %d)\n",
reg_size, nr_cells);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.