bitkeeper revision 1.1159.265.3 (42319571gIMQdofIDztktCfg053n-A)

Fix some errors in default error handling.

Signed-off-by: Mike Wray <mike.wray@hp.com>

tools/python/xen/xend/Args.py

@@ -78,6 +78,8 @@ class Args:
                 val = str(v)
             elif type == 'sxpr':
                 val = self.sxpr(v)
+            elif type == 'bool':
+                val = self.bool(v)
             else:
                 raise ArgError('invalid type:' + str(type))
             return val
@@ -86,6 +88,9 @@ class Args:
         except StandardError, ex:
             raise ArgError(str(ex))
 
+    def bool(self, v):
+        return (v.lower() in ['on', 'yes', '1', 'true'])
+
     def sxpr(self, v):
         if isinstance(v, types.ListType):
             val = v

tools/python/xen/xend/server/SrvBase.py

@@ -106,7 +106,8 @@ class SrvBase(resource.Resource):
         try:
             val = op_method(op, req)
         except Exception, err:
-            return self._perform_err(err, op, req)
+            self._perform_err(err, op, req)
+            return ''
             
         if isinstance(val, defer.Deferred):
             val.addCallback(self._perform_cb, op, req, dfr=1)

tools/python/xen/xend/server/SrvDir.py

@@ -88,7 +88,7 @@ class SrvDir(SrvBase):
                 req.write('</body></html>')
             return ''
         except Exception, ex:
-            self._perform_err(ex, req)
+            self._perform_err(ex, "GET", req)
             
     def ls(self, req, use_sxp=0):
         url = req.prePathURL()