From e057bfa6c7fe3699722a0e629611d91c97eb80b4 Mon Sep 17 00:00:00 2001 From: Marek Marczykowski Date: Sun, 5 Jun 2011 16:53:03 +0200 Subject: [PATCH] xen.lowlevel.xl: Return None on empty domain name Previously PyString_FromString(NULL) was called, which caused assertion failure. Signed-off-by: Marek Marczykowski xen-unstable changest: 23606:cc2f376d0cd9 Backport-requested-by: Marek Marczykowski Committed-by: Ian Jackson --- tools/python/xen/lowlevel/xl/xl.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tools/python/xen/lowlevel/xl/xl.c b/tools/python/xen/lowlevel/xl/xl.c index 14ad809f0f..a637a65fb7 100644 --- a/tools/python/xen/lowlevel/xl/xl.c +++ b/tools/python/xen/lowlevel/xl/xl.c @@ -412,14 +412,16 @@ static PyObject *pyxl_domid_to_name(XlObject *self, PyObject *args) { char *domname; int domid; - PyObject *ret; + PyObject *ret = Py_None; if ( !PyArg_ParseTuple(args, "i", &domid) ) return NULL; domname = libxl_domid_to_name(&self->ctx, domid); - ret = PyString_FromString(domname); - free(domname); + if (domname) { + ret = PyString_FromString(domname); + free(domname); + } return ret; }