From f35d7e08ced6dab2ceef467abdb5e823f445d77a Mon Sep 17 00:00:00 2001 From: Jan Beulich Date: Tue, 1 Sep 2026 09:59:12 +0200 Subject: [PATCH] altp2m: address Misra 2.1 rule violation The stub altp2m_vcpu_idx() is recognized as "noreturn" function lacking respective annotation (or having a return statement), which hence is deemed unreachable code by Misra / Eclair. All call sites are guarded by altp2m_active() checks, hence an inline function isn't needed. A declaration will suffice, with call sites then getting DCE-d. No functional change. Signed-off-by: Jan Beulich Reviewed-by: Stefano Stabellini --- xen/include/asm-generic/altp2m.h | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/xen/include/asm-generic/altp2m.h b/xen/include/asm-generic/altp2m.h index 39865a842a..58247c4a8b 100644 --- a/xen/include/asm-generic/altp2m.h +++ b/xen/include/asm-generic/altp2m.h @@ -14,13 +14,8 @@ static inline bool altp2m_active(const struct domain *d) return false; } -/* Alternate p2m VCPU */ -static inline unsigned int altp2m_vcpu_idx(const struct vcpu *v) -{ - /* Not implemented on GENERIC, should not be reached. */ - BUG(); - return 0; -} +/* Alternate p2m VCPU - placeholder on GENERIC */ +unsigned int altp2m_vcpu_idx(const struct vcpu *v); #endif /* __ASM_GENERIC_ALTP2M_H */