mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 10:11:27 +01:00
xentrace: correct formula to calculate t_info_pages
The current formula to calculate t_info_pages, based on the initial code, is slightly incorrect. It may allocate more than needed. Each cpu has some pages/mfns stored as uint32_t. That list is stored with an offset at tinfo. Signed-off-by: Olaf Hering <olaf@aepfle.de> Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
This commit is contained in:
1 parent
0be477c900
commit
fbf96e6725
1 file changed
+3
-4
+3
-4
@@ -110,7 +110,7 @@ static int calculate_tbuf_size(unsigned int pages)
|
||||
{
|
||||
struct t_buf dummy;
|
||||
typeof(dummy.prod) size;
|
||||
unsigned int t_info_words, t_info_bytes;
|
||||
unsigned int t_info_words;
|
||||
|
||||
/* force maximum value for an unsigned type */
|
||||
size = -1;
|
||||
@@ -125,9 +125,8 @@ static int calculate_tbuf_size(unsigned int pages)
|
||||
pages = size;
|
||||
}
|
||||
|
||||
t_info_words = num_online_cpus() * pages + t_info_first_offset;
|
||||
t_info_bytes = t_info_words * sizeof(uint32_t);
|
||||
t_info_pages = PFN_UP(t_info_bytes);
|
||||
t_info_words = num_online_cpus() * pages * sizeof(uint32_t);
|
||||
t_info_pages = PFN_UP(t_info_first_offset + t_info_words);
|
||||
printk(XENLOG_INFO "xentrace: requesting %u t_info pages "
|
||||
"for %u trace pages on %u cpus\n",
|
||||
t_info_pages, pages, num_online_cpus());
|
||||
|
||||