Joe Perches
31aa8113a8
get_maintainer: fix perl 5.22/5.24 deprecated/incompatible "\C" use
...
Perl 5.22 emits a deprecated message when "\C" is used in a regex. Perl
5.24 will disallow it altogether.
Fix it by using [A-Z] instead of \C.
[ Upstream commit ce8155f7a3d59ce868ea16d8891edda4d865e873 ]
Signed-off-by: Olaf Hering <olaf@aepfle.de >
Cc: Ian Campbell <ian.campbell@citrix.com >
Cc: Ian Jackson <ian.jackson@eu.citrix.com >
Cc: Jan Beulich <jbeulich@suse.com >
Cc: Keir Fraser <keir@xen.org >
Cc: Tim Deegan <tim@xen.org >
Acked-by: Ian Campbell <ian.campbell@citrix.com >
2015-11-24 16:18:16 +00:00
Julien Grall
8342b121cd
scripts/get_maintainer.pl: Correctly CC the maintainers
...
The current script is setting $email_remove_duplicates to 1 by default, on
complex patch (see [1]), this will result to ommitting randomly some
maintainers.
This is because, the script will:
1) Get the list of maintainers of the file (incidentally all the
maintainers in "THE REST" role are added). If the email address already
exists in the global list, skip it. => The role will be lost
2) Filter the list to remove the entry with "THE REST" role
So if a maintainers is marked with "THE REST" role on the first file and
actually be an x86 maintainers on the script, the script will only retain
the "THE REST" role. During the filtering step, this maintainers will
therefore be dropped.
This patch fixes this by setting $email_remove_duplicates to 0 by default.
The new behavior of the script will be:
1) Append the list of maintainers for every file
2) Filter the list to remove the entry with "THE REST" role
3) Remove duplicated email address
Example:
Patch: https://patches.linaro.org/41083/
Before the patch:
Daniel De Graaf <dgdegra@tycho.nsa.gov >
Ian Jackson <ian.jackson@eu.citrix.com >
Stefano Stabellini <stefano.stabellini@eu.citrix.com >
Ian Campbell <ian.campbell@citrix.com >
Wei Liu <wei.liu2@citrix.com >
George Dunlap <george.dunlap@eu.citrix.com >
xen-devel@lists.xen.org
After the patch:
Daniel De Graaf <dgdegra@tycho.nsa.gov >
Ian Jackson <ian.jackson@eu.citrix.com >
Stefano Stabellini <stefano.stabellini@eu.citrix.com >
Ian Campbell <ian.campbell@citrix.com >
Wei Liu <wei.liu2@citrix.com >
Stefano Stabellini <stefano.stabellini@citrix.com >
Tim Deegan <tim@xen.org >
Keir Fraser <keir@xen.org >
Jan Beulich <jbeulich@suse.com >
George Dunlap <george.dunlap@eu.citrix.com >
xen-devel@lists.xen.org
[1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html
Signed-off-by: Julien Grall <julien.grall@linaro.org >
CC: Don Slutz <dslutz@verizon.com >
Acked-by: Ian Campbell <ian.campbell@citrix.com >
2014-11-25 14:07:15 +00:00
Don Slutz
d6738db02d
get_maintainer.pl: Adjust to Xen workflow
...
Based on feedback from reviewers:
* Disable git fallback by default: it has a tendency to mail
anyone who did a single oneline change and should not be
necessary for a project of Xen's size.
* Disable rolestats: Makes cut-and-paste from the output into the
commit message easy.
* Drop "THE REST" fallback: Don't spam Keir *too* much.
Signed-off-by: Don Slutz <dslutz@verizon.com >
Acked-by: Ian Campbell <ian.campbell@citrix.com >
[ijc -- expanded the changelog]
2013-11-19 14:02:23 +00:00
Don Slutz
f85e314d26
get_maintainer.pl: Convert to Xen tree
...
Signed-off-by: Don Slutz <dslutz@verizon.com >
Acked-by: Ian Campbell <ian.campbell@citrix.com >
2013-11-19 14:02:23 +00:00
Don Slutz
9205d0b4e7
Add linux version of get_maintainer.pl
...
This is get_maintainer.pl from linux commit bbbe96ed899e8ebde1a12d28f10461eb8bef1074
Tag at time of commit: v3.9-2313-gbbbe96e
Was released as: v3.10-0-g8bb495e
Signed-off-by: Don Slutz <dslutz@verizon.com >
Acked-by: Ian Campbell <ian.campbell@citrix.com >
2013-11-19 14:02:22 +00:00
Joe Perches
Julien Grall
Don Slutz