Jennifer Herbert b9dbe33d15 libxc: Fix misleading use of strncpy code in build_hvm_info() ...

hvm_info->signature is not a string, but an 64 bit int, and is not
NULL terminated.  The use of strncpy to populate it is inappropriate and
potentially misleading.  A cursory glance might have you thinking someone
had miscounted the length of the string literal - not realising it was
intentionally cropping of the null termination.
Also, since we wish to initialise all of hvm_info->signature, and
certainly no more, the use of sizeof is safer.

Coverity-ID: 1198710

Signed-off-by: Jennifer Herbert <jennifer.herbert@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

2015-07-03 16:48:18 +01:00

..

include

x86/HVM: avoid pointer wraparound in bufioreq handling

2015-06-18 16:44:15 +02:00

COPYING

# HG changeset patch

2010-08-24 18:42:59 +01:00

Makefile

libxc: use xc_netbsd.c for rump kernel

2015-06-25 12:10:01 +01:00

xc_arinc653.c

arinc: Add poolid parameter to scheduler get/set functions

2013-12-04 14:02:10 +00:00

xc_bitops.h

libxc/save: reuse send_dirty_pages() in send_all_pages()

2015-05-14 13:03:57 +01:00

xc_compression.c

tools/libxc: remove double inclusion of errno.h

2014-03-10 16:50:17 +00:00

xc_core_arm.c

libxc: Introduce xc_domain_nr_gpfns as a cousin of xc_domain_maximum_gpfn.

2015-03-30 16:07:30 +01:00

xc_core_arm.h

Fix emacs local variable block to use correct C style variable.

2013-02-21 16:12:46 +00:00

xc_core_x86.c

libxc: Introduce xc_domain_nr_gpfns as a cousin of xc_domain_maximum_gpfn.

2015-03-30 16:07:30 +01:00

xc_core_x86.h

Fix emacs local variable block to use correct C style variable.

2013-02-21 16:12:46 +00:00

xc_core.c

tools/libxc: Annotate xc_report_error with __attribute__((format))

2014-06-10 13:46:45 +01:00

xc_core.h

libxc: introduce a per architecture scratch pfn for temporary grant mapping

2015-01-27 16:30:35 +00:00

xc_cpu_hotplug.c

# HG changeset patch

2010-08-24 18:42:59 +01:00

xc_cpufeature.h

x86/tools: expose SMAP to HVM guests

2014-05-12 17:05:33 +02:00

xc_cpuid_x86.c

libxc: Expose the 1GB pages cpuid flag to guest

2015-01-08 13:50:06 +00:00

xc_cpupool.c

libxc: Replaces tabs with spaces in xc_cpupool_freeinfo

2015-03-20 16:04:35 +00:00

xc_csched2.c

# HG changeset patch

2010-08-24 18:42:59 +01:00

xc_csched.c

libxc: Implement SCHEDOP sysctl for credit scheduler

2012-02-23 10:17:50 +00:00

xc_dom_arm.c

tools/libxc: Allocate magic page for mem access on ARM

2015-04-22 14:08:29 +01:00

xc_dom_armzimageloader.c

tools: arm: remove code to check for a DTB appended to the kernel

2014-05-14 15:12:01 +01:00

xc_dom_binloader.c

Revert "tools: libxc: flush data cache after loading images into guest memory"

2014-01-10 16:59:01 +00:00

xc_dom_boot.c

x86/domctl: improve XEN_DOMCTL_hypercall_init error handling

2015-03-13 16:31:27 +01:00

xc_dom_bzimageloader.c

libxc: use xc_dom_panic when decompressor is not supported

2015-03-11 11:36:38 +00:00

xc_dom_compat_linux.c

libxc: Prevent dereferencing NULL pointers returned from xc_dom_allocate()

2015-07-03 16:47:13 +01:00

xc_dom_core.c

libxc: add p2m_size to xc_dom_image

2015-03-18 12:04:54 +00:00

xc_dom_decompress_lz4.c

libxc: don't leak buffer containing the uncompressed PV kernel

2014-11-25 15:53:53 +00:00

xc_dom_decompress_unsafe_bzip2.c

libxc: Add unsafe decompressors

2013-04-22 12:46:30 +01:00

xc_dom_decompress_unsafe_lzma.c

libxc: Add unsafe decompressors

2013-04-22 12:46:30 +01:00

xc_dom_decompress_unsafe_lzo1x.c

libxc: Fix stub domain build breakage

2014-07-04 09:47:01 +01:00

xc_dom_decompress_unsafe_xz.c

tools/libxc: Shuffle definitions and uses of min()/max() macros

2014-07-18 13:38:08 +01:00

xc_dom_decompress_unsafe.c

libxc: Add unsafe decompressors

2013-04-22 12:46:30 +01:00

xc_dom_decompress_unsafe.h

libxc: Add unsafe decompressors

2013-04-22 12:46:30 +01:00

xc_dom_decompress.h

libxc: add LZ4 decompression support

2013-10-07 09:42:51 +02:00

xc_dom_elfloader.c

libxc: fix xc_dom_load_elf_symtab

2015-06-17 11:57:39 +01:00

xc_dom_x86.c

tools/libxc: Batch memory allocations for PV guests

2015-06-17 11:39:56 +01:00

xc_domain_restore.c

tools/libxc: Migration v2 framework

2015-05-05 14:30:44 +01:00

xc_domain_save.c

libxc: delete sent_last_iter

2015-06-25 13:01:22 +01:00

xc_domain.c

x86/HVM: avoid pointer wraparound in bufioreq handling

2015-06-18 16:44:15 +02:00

xc_efi.h

# HG changeset patch

2010-08-24 18:42:59 +01:00

xc_elf.h

# HG changeset patch

2010-08-24 18:42:59 +01:00

xc_evtchn.c

Fix emacs local variable block to use correct C style variable.

2013-02-21 16:12:46 +00:00

xc_flask.c

libxc: add missing xc_hypercall_bounce_pre calls

2015-06-03 11:12:01 +01:00

xc_foreign_memory.c

tools/libxc: assign positive values to errno

2014-03-10 16:50:58 +00:00

xc_freebsd_osdep.c

libxc: Propagate errno from hypercall instead of anything else.

2015-03-20 16:04:35 +00:00

xc_freebsd.c

libxc: add support for FreeBSD

2014-06-18 17:17:49 +01:00

xc_gnttab.c

tools/libxc: Annotate xc_report_error with __attribute__((format))

2014-06-10 13:46:45 +01:00

xc_hcall_buf.c

libxc: Propagate errno from hypercall instead of anything else.

2015-03-20 16:04:35 +00:00

xc_hvm_build_arm.c

Fix emacs local variable block to use correct C style variable.

2013-02-21 16:12:46 +00:00

xc_hvm_build_x86.c

libxc: Fix misleading use of strncpy code in build_hvm_info()

2015-07-03 16:48:18 +01:00

xc_kexec.c

libxc: add API for kexec hypercall

2013-11-12 11:47:07 +01:00

xc_linux_osdep.c

libxc: Propagate errno from hypercall instead of anything else.

2015-03-20 16:04:35 +00:00

xc_linux.c

Fix emacs local variable block to use correct C style variable.

2013-02-21 16:12:46 +00:00

xc_mem_access.c

xen/vm_event: Add RESUME option to vm_event_op domctl

2015-04-16 09:43:11 +01:00

xc_mem_paging.c

xen/vm_event: Add RESUME option to vm_event_op domctl

2015-04-16 09:43:11 +01:00

xc_memshr.c

xen/vm_event: Add RESUME option to vm_event_op domctl

2015-04-16 09:43:11 +01:00

xc_minios.c

tools/libxc: Introduce ARRAY_SIZE() and replace handrolled examples

2014-06-10 16:04:03 +01:00

xc_misc.c

libxl: Add interface for querying hypervisor about PCI topology

2015-05-13 15:03:38 +01:00

xc_monitor.c

vm_event: clean up control-register-write vm_events and add XCR0 event

2015-06-05 12:20:18 +02:00

xc_msr_x86.h

tools, docs: add total/local memory bandwith monitoring

2015-03-05 16:27:49 +00:00

xc_netbsd.c

Revert "tools: libxc: flush data cache after loading images into guest memory"

2014-01-10 16:59:01 +00:00

xc_nomigrate.c

libxc, libxl, hvmloader: strip out outdated VM generation ID implementation

2014-06-27 14:13:22 +01:00

xc_offline_page.c

libxc: Check xc_maximum_ram_page for negative return values.

2015-03-20 16:07:35 +00:00

xc_pagetab.c

libxc: introduce xc_domain_get_guest_width()

2013-09-13 13:06:28 +01:00

xc_physdev.c

libxc: xc_physdev_map return -1 and populate errno.

2015-03-20 16:04:35 +00:00

xc_pm.c

libxc: Fix xc_pm API calls to return negative error and stash error in errno.

2015-03-20 16:04:35 +00:00

xc_private.c

libxc/progress: Extend the progress interface

2015-05-05 14:29:45 +01:00

xc_private.h

libxc/progress: Extend the progress interface

2015-05-05 14:29:45 +01:00

xc_psr.c

tools, docs: add total/local memory bandwith monitoring

2015-03-05 16:27:49 +00:00

xc_resource.c

libxc: provide interface for generic resource access

2014-10-06 12:35:55 +02:00

xc_resume.c

tools/libxc: Improve the *_FIELD() macros

2014-06-27 14:13:22 +01:00

xc_rt.c

libxc: add rtds scheduler

2014-09-23 14:40:07 +01:00

xc_sedf.c

# HG changeset patch

2010-08-24 18:42:59 +01:00

xc_solaris.c

Revert "tools: libxc: flush data cache after loading images into guest memory"

2014-01-10 16:59:01 +00:00

xc_sr_common_x86_pv.c

tools/libxc: x86 PV common code

2015-05-05 14:30:46 +01:00

xc_sr_common_x86_pv.h

tools/libxc: x86 PV common code

2015-05-05 14:30:46 +01:00

xc_sr_common_x86.c

tools/libxc: x86 common code

2015-05-05 14:30:46 +01:00

xc_sr_common_x86.h

tools/libxc: x86 common code

2015-05-05 14:30:46 +01:00

xc_sr_common.c

libxc/migration: Specification update for CHECKPOINT records

2015-05-14 13:01:11 +01:00

xc_sr_common.h

libxc/restore: implement Remus checkpointed restore

2015-05-29 12:25:01 +01:00

xc_sr_restore_x86_hvm.c

libxc/restore: split read/handle qemu info

2015-05-14 13:04:15 +01:00

xc_sr_restore_x86_pv.c

tools/libxc: x86 PV restore code

2015-05-05 14:30:47 +01:00

xc_sr_restore.c

libxc/restore: implement Remus checkpointed restore

2015-05-29 12:25:01 +01:00

xc_sr_save_x86_hvm.c

libxc/save: Adjust stream-position callbacks for checkpointed streams

2015-05-14 13:00:57 +01:00

xc_sr_save_x86_pv.c

libxc/save: Adjust stream-position callbacks for checkpointed streams

2015-05-14 13:00:57 +01:00

xc_sr_save.c

libxc/save: implement Remus checkpointed save

2015-05-29 12:25:00 +01:00

xc_sr_stream_format.h

libxc/migration: Specification update for CHECKPOINT records

2015-05-14 13:01:11 +01:00

xc_suspend.c

tools/libxc: use XEN_RUN_DIR for SUSPEND_LOCK_FILE

2014-09-23 10:15:43 +01:00

xc_tbuf.c

libxc/xentrace: Use xc_cpumap_t for xc_tbuf_set_cpu_mask

2015-05-08 14:54:53 +01:00

xc_tmem.c

libxc: Fix xc_tmem_control to return proper error.

2015-03-20 16:06:42 +00:00

xc_vm_event.c

xen/vm_event: Add RESUME option to vm_event_op domctl

2015-04-16 09:43:11 +01:00

xenctrl_osdep_ENOSYS.c

libxc: fix printf formatting error surfaced by 66f8c6

2014-06-27 14:13:23 +01:00

xg_private.c

libxc: remove include of malloc.h

2014-05-02 13:34:34 +01:00

xg_private.h

tools/libxc: Shuffle definitions and uses of min()/max() macros

2014-07-18 13:38:08 +01:00

xg_save_restore.h

xen/mem_event: Cleanup mem_event names in rings, functions and domctls

2015-04-09 11:40:17 +01:00

xtl_core.c

libxc/progress: Extend the progress interface

2015-05-05 14:29:45 +01:00

xtl_logger_stdio.c

libxc: remove usage of "daylight" variable

2014-05-02 13:34:34 +01:00