Ian Jackson 4bf3ca7bdb tools/hotplug: Fix hotplug hook script arrangements not to always fail ...

The new feature introduced in 23401:a44b12ee2fd3 was broken; it in
general always fails, at least if there are no hotplug scripts.

If there are no hooks, call_hooks ends up running this:
  [ -x ".....*.hook" ] && . "..... *.hook"

This does not directly trigger set -e and sigerr.  However, it is the
last command exected in call_hooks.  So the return status of
call_hooks is an error, and thus a sigerr happens when call_hooks
returns.

The bug affects xl and xm.  However xl does not detect failure of the
hotplug script.

Change the script to use if...then rather than &&, as the latter has
very confusing and undesirable semantics.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

2011-06-03 15:04:30 +01:00

..

common

build: Make XEN_ROOT an absolute path.

2011-03-17 10:36:25 +00:00

Linux

tools/hotplug: Fix hotplug hook script arrangements not to always fail

2011-06-03 15:04:30 +01:00

NetBSD

build: Make XEN_ROOT an absolute path.

2011-03-17 10:36:25 +00:00

Makefile

build: Make XEN_ROOT an absolute path.

2011-03-17 10:36:25 +00:00