Jane Malalane 1787cc1679 libs/guest: Move the guest ABI check earlier into xc_dom_parse_image() ...

Xen may not support 32-bit PV guest for a number of reasons (lack of
CONFIG_PV32, explicit pv=no-32 command line argument, or implicitly
due to CET being enabled) and advertises this to the toolstack via the
absence of xen-3.0-x86_32p ABI.

Currently, when trying to boot a 32-bit PV guest, the ABI check is too
late and the build explodes in the following manner yielding an
unhelpful error message:

  xc: error: panic: xg_dom_boot.c:121: xc_dom_boot_mem_init: can't allocate low memory for domain: Out of memory
  libxl: error: libxl_dom.c:586:libxl__build_dom: xc_dom_boot_mem_init failed: Operation not supported
  libxl: error: libxl_create.c:1573:domcreate_rebuild_done: Domain 1:cannot (re-)build domain: -3
  libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 1:Non-existant domain
  libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 1:Unable to destroy guest
  libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 1:Destruction of domain failed

Move the ABI check earlier into xc_dom_parse_image() along with other
ELF-note feature checks.  With this adjustment, it now looks like
this:

  xc: error: panic: xg_dom_boot.c:88: xc_dom_compat_check: guest type xen-3.0-x86_32p not supported by xen kernel, sorry: Invalid kernel
  libxl: error: libxl_dom.c:571:libxl__build_dom: xc_dom_parse_image failed
  domainbuilder: detail: xc_dom_release: called
  libxl: error: libxl_create.c:1573:domcreate_rebuild_done: Domain 11:cannot (re-)build domain: -3
  libxl: error: libxl_domain.c:1182:libxl__destroy_domid: Domain 11:Non-existant domain
  libxl: error: libxl_domain.c:1136:domain_destroy_callback: Domain 11:Unable to destroy guest
  libxl: error: libxl_domain.c:1063:domain_destroy_cb: Domain 11:Destruction of domain failed

Suggested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Jane Malalane <jane.malalane@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Jackson <iwj@xenproject.org>

2021-08-19 18:34:53 +01:00

..

COPYING

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

Makefile

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_core_arm.c

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_core_arm.h

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_core_x86.c

tools/libs/guest: make some definitions private to libxenguest

2021-06-04 18:56:46 +01:00

xg_core_x86.h

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_core.c

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_core.h

tools/libs/guest: make some definitions private to libxenguest

2021-06-04 18:56:46 +01:00

xg_cpuid_x86.c

tools/libxenguest: Fix max_extd_leaf calculation for legacy restore

2021-07-05 11:30:14 +01:00

xg_dom_arm.c

tools: Fix CPSR/SPSR print size

2021-07-07 13:07:46 +01:00

xg_dom_armzimageloader.c

tools/lixenguest: hide struct elf_dom_parms layout from users

2020-10-01 13:58:48 +02:00

xg_dom_binloader.c

tools/lixenguest: hide struct elf_dom_parms layout from users

2020-10-01 13:58:48 +02:00

xg_dom_boot.c

libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()

2021-08-19 18:34:53 +01:00

xg_dom_bzimageloader.c

libxenguest: simplify kernel decompression

2021-04-12 12:26:18 +02:00

xg_dom_compat_linux.c

tools/libs: merge xenctrl_dom.h into xenguest.h

2020-10-01 13:58:42 +02:00

xg_dom_core.c

libs/guest: Move the guest ABI check earlier into xc_dom_parse_image()

2021-08-19 18:34:53 +01:00

xg_dom_decompress_lz4.c

libxenguest: drop now unused le32_to_cpup() from lz4 decompression

2021-01-27 17:07:57 +01:00

xg_dom_decompress_unsafe_bzip2.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_dom_decompress_unsafe_lzma.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_dom_decompress_unsafe_lzo1x.c

autoconf: check endian.h include path

2021-02-10 11:10:55 +00:00

xg_dom_decompress_unsafe_xz.c

autoconf: check endian.h include path

2021-02-10 11:10:55 +00:00

xg_dom_decompress_unsafe_zstd.c

autoconf: check endian.h include path

2021-02-10 11:10:55 +00:00

xg_dom_decompress_unsafe.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_dom_decompress_unsafe.h

xen/decompress: make helper symbols static

2021-03-30 14:33:48 +02:00

xg_dom_decompress.h

tools/libs: merge xenctrl_dom.h into xenguest.h

2020-10-01 13:58:42 +02:00

xg_dom_elfloader.c

libelf: don't attempt to parse __xen_guest for PVH

2021-05-28 09:13:32 +02:00

xg_dom_hvmloader.c

Replace FSF street address with canonical URL (again)

2021-06-28 11:17:14 +01:00

xg_dom_x86.c

tools/libs: guest: Use const whenever we point to literal strings

2021-05-18 14:54:05 +01:00

xg_domain.c

libxenguest: complete loops in xc_map_domain_meminfo()

2021-08-13 16:49:10 +02:00

xg_nomigrate.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_offline_page.c

tools/libs: move xc_core* from libxenctrl to libxenguest

2021-06-04 18:56:46 +01:00

xg_private.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_private.h

libs/guest: Move struct xc_cpu_policy into xg_private.h

2021-06-15 20:50:32 +01:00

xg_resume.c

tools/libs/guest: make some definitions private to libxenguest

2021-06-04 18:56:46 +01:00

xg_save_restore.h

tools/libxenguest: move M2P macros to xg_private.h

2021-01-05 17:11:43 +00:00

xg_sr_common_x86_pv.c

tools/libs/guest: fix save and restore of pv domains after 32-bit de-support

2021-06-07 15:43:35 +01:00

xg_sr_common_x86_pv.h

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_common_x86.c

libs/guest: Don't hide the indirection on xc_cpu_policy_t

2021-05-05 20:20:42 +01:00

xg_sr_common_x86.h

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_common.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_common.h

tools/migration: unify type checking for data pfns in migration stream

2021-07-06 10:49:58 +01:00

xg_sr_restore_x86_hvm.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_restore_x86_pv.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_restore.c

tools/migration: unify type checking for data pfns in migration stream

2021-07-06 10:49:58 +01:00

xg_sr_save_x86_hvm.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_sr_save_x86_pv.c

revert "tools/libs/guest: fix max_pfn setting in map_p2m()"

2021-06-14 14:39:52 +02:00

xg_sr_save.c

libxenguest: fix off-by-1 in colo-secondary-bitmap merging

2021-08-13 16:49:46 +02:00

xg_sr_stream_format.h

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00

xg_suspend.c

tools/libxc: move libxenguest to tools/libs/guest

2020-09-09 10:57:25 +00:00