Andrew Cooper a306f8107a tools/foreign: avoid using alignment directives when not appropriate ...

The foreign header generation blindly replaces 'uint64_t' with '__align8__
uint64_t', to get correct alignment when built as 32bit.  This is correct in
most circumstances, but Clang objects to two specific uses.

 * Inside a sizeof() expression
 * As part of a typecast

An example error looks like:

/local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:204:44:
error: 'aligned' attribute ignored when parsing type [-Werror,-Wignored-attributes]
    __align8__ uint64_t evtchn_mask[sizeof(__align8__ uint64_t) * 8];
                                           ^~~~~~~~~~
/local/xen.git/tools/libxc/../../tools/include/xen/foreign/x86_64.h:13:36:
note: expanded from macro '__align8__'
                                   ^~~~~~~~~~~

This sedary is sufficient to fix all the bad examples without touching any of
the legitimate uses, and is more simple than teaching mkheader.py how to parse
C.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>

2016-03-10 16:45:55 +01:00

..

xen-external

bsd-sys-queue-h-seddery: Massage `offsetof'

2015-07-15 11:22:52 +01:00

xen-foreign

tools/foreign: avoid using alignment directives when not appropriate

2016-03-10 16:45:55 +01:00

xen-sys

tools: update outdated header comment on privcmd.h

2015-12-02 15:24:14 +00:00

Makefile

tools: Expose XSM Flask initial SIDs list to tools

2015-05-21 15:25:47 +01:00