Matthew Daley 2d97f52713 xenconsole: adjust pty opening error checking and handling ...

Currently we check the pty path received from xenstore with access(); if
it indicates that the pty is not accessible, we loop around and wait for
a new path to appear in xenstore.

This has several issues:
* If a path has been written to xenstore, it can be assumed that that
  pty should already be accessible to xenconsole, and hence any error
  that occurs while trying to open it should be fatal and not ignored
* If access() indicates no access to the pty, the memory allocated for
  the path is leaked when going around the loop again
* The accessibility of the pty could change between the access() and
  open() calls, leading to a TOCTOU race (this is what Coverity is
  complaining about).

By removing the explicit access() check and just erroring out whenever
open() fails, we fix all these issues.

Coverity-ID: 1056047
Signed-off-by: Matthew Daley <mattd@bugfuzz.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

2013-12-16 11:55:22 +00:00

..

client

xenconsole: adjust pty opening error checking and handling

2013-12-16 11:55:22 +00:00

daemon

tools/xenconsoled: Fix file handle leaks

2013-11-25 12:19:31 +00:00

testsuite

build: Make XEN_ROOT an absolute path.

2011-03-17 10:36:25 +00:00

Makefile

tools/build: Introduce {PREPEND,APPEND}_{LIB,INCLUDES}

2011-11-14 18:14:07 +00:00