mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 18:21:39 +01:00
From their introduction all xc_hypercall_bounce_pre() uses, when they failed, would properly cause exit from the function including cleanup, yet without informing the caller of the failure. Purge the unlock_1 label for being both pointless and mis-named. An earlier attempt to switch to the usual split between return value and errno wasn't quite complete. HWP work made the cleanup of the "available governors" array conditional, neglecting the fact that the condition used may not be the condition that was used to allocate the buffer (as the structure field is updated upon getting back EAGAIN). Since cleanup can be done even if no buffer was allocated, drop the conditional there again. Fixes:4513025a87("libxc: convert sysctl interfaces over to hypercall buffers") Amends:73367cf3b4("libxc: Fix xc_pm API calls to return negative error and stash error in errno") Fixes:31e264c672("pmstat&xenpm: Re-arrage for cpufreq union") Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Jason Andryuk <jason.andryuk@amd.com> Reviewed-by: Anthony PERARD <anthony.perard@vates.tech>