Andrew Cooper ca4c1848f1 tools/blktap2: Fix use of uninitialised variable in _tap_list_join3() ...

Clang points out:

  tap-ctl-list.c:457:28: error: variable 'entry' is uninitialized when
  used here [-Werror,-Wuninitialized]
          for (; *_entry != NULL; ++entry) {
                                    ^~~~~

The content of that loop clearly was meant to iterate over _entry rather than
entry, so is fixed to do so.  This presumably fixes a memory leak when
tapdisks get orphed, as only the first item on the list got freed.

There is no use of entry at all.  It is referenced in a
list_for_each_entry(tl, &tap->list, entry) construct, but this is just a
member name, and not a reference to local scope variable of the same name.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>

2016-04-27 20:31:34 +01:00

..

Makefile

tools: replace private LIBDIR with automake libdir

2015-05-21 15:12:11 +01:00

tap-ctl-allocate.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-attach.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-check.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-close.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-create.c

libxl: propagate error from tap_ctl_spawn.

2011-11-28 17:42:40 +00:00

tap-ctl-destroy.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-detach.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-free.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-ipc.c

tools/blktap2: Handle read/write interrupts in blktap2 control plane.

2013-03-28 14:35:23 +00:00

tap-ctl-list.c

tools/blktap2: Fix use of uninitialised variable in _tap_list_join3()

2016-04-27 20:31:34 +01:00

tap-ctl-major.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-open.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-pause.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-spawn.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl-unpause.c

blktap2: The tap-ctl userspace control utility and library.

2010-06-08 08:05:09 +01:00

tap-ctl.c

blktap2: Fix broken tap-ctl-list type/path filter logic

2010-06-10 08:25:55 +01:00

tap-ctl.h

libxl: attempt to cleanup tapdisk processes on disk backend destroy.

2011-09-28 16:42:11 +01:00