xen-project/xen
1
0 Fork 1
mirror of https://github.com/xen-project/xen.git synced 2026-10-28 18:21:39 +01:00
Code Issues Activity
Files
d2ecf97f911fc00a85b34b70ca311b5d355a9756
xen/tools/libs/light
T
History
Jason Andryuk d2ecf97f91 libxl: Don't segfault on soft-reset failure 
If domain_soft_reset_cb can't rename the save file, it doesn't call
initiate_domain_create() and calls domcreate_complete().

Skipping initiate_domain_create() means dcs->console_wait is
uninitialized and all 0s.

We have:
  domcreate_complete()
    libxl__xswait_stop()
      libxl__ev_xswatch_deregister().

The uninitialized slotnum 0 is considered valid (-1 is the invalid
sentinel), so the NULL pointer path to passed to xs_unwatch() which
segfaults.

libxl__ev_xswatch_deregister:watch w=0x12bc250 wpath=(null) token=0/0: deregister slotnum=0

Move dcs->console_xswait initialization into the callers of
initiate_domain_create, do_domain_create() and do_domain_soft_reset(),
so it is initialized along with the other dcs state.

Fixes: c57e6ebd8c ("(lib)xl: soft reset support")
Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
2022-04-01 17:01:57 +01:00
..
check-libxl-api-rules
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
CODING_STYLE
libxl: CODING_STYLE: Explicitly deprecate #ifdef
2021-10-13 15:10:38 +01:00
flexarray.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
flexarray.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
gentest.py
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
gentypes.py
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
idl.py
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
idl.txt
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_9pfs.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_aoutils.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_arch.h
tools/libxl: Modify libxl__arch_domain_init_hw_description...
2021-10-15 12:40:21 -07:00
libxl_arm_acpi.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_arm_no_acpi.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_arm.c
arm/libxl: Emulated PCI device tree node in libxl
2021-10-15 12:40:21 -07:00
libxl_arm.h
tools/libs: merge xenctrl_dom.h into xenguest.h
2020-10-01 13:58:42 +02:00
libxl_bootloader.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_checkpoint_device.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_colo_nic.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_colo_proxy.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_colo_qdisk.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_colo_restore.c
libxc: split xc_logdirty_control() from xc_shadow_control()
2021-09-03 15:09:48 +02:00
libxl_colo_save.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_colo.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_console.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_convert_callout.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_cpuid.c
x86/spec-ctrl: Support Intel PSFD for guests
2022-02-08 18:00:08 +00:00
libxl_cpupool.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_create.c
libxl: Don't segfault on soft-reset failure
2022-04-01 17:01:57 +01:00
libxl_device.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_disk.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_dm.c
gnttab: allow setting max version per-domain
2021-11-08 15:10:05 +00:00
libxl_dom_save.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_dom_suspend.c
libxl: Fix domain soft reset state handling
2021-03-18 14:56:33 +01:00
libxl_dom.c
tools: Use config.h from autoconf instead of "buildmakevars2header"
2021-12-16 20:27:12 +00:00
libxl_domain.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_event.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_exec.c
tools: drop all deprecated usages of xs_*_open() and friends in tools
2020-10-08 12:47:59 +00:00
libxl_flask.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_fork.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_freebsd.c
libs/light: Switch NetBSD to QEMU_XEN
2021-01-29 22:50:08 +00:00
libxl_genid.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_internal.c
x86/msr: introduce an option for compatible MSR behavior selection
2021-03-12 08:59:56 +01:00
libxl_internal.h
libxl: constify libxl__stubdomain_is_linux
2022-03-31 19:50:03 +01:00
libxl_json.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_libfdt_compat.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_libfdt_compat.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_linux.c
libs/light: Switch NetBSD to QEMU_XEN
2021-01-29 22:50:08 +00:00
libxl_mem.c
tool/libs/light: Fix libxenlight gcc warning
2020-10-08 12:56:03 +00:00
libxl_netbsd.c
libs/light: make it build without setresuid()
2021-01-29 22:50:08 +00:00
libxl_netbuffer.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_nic.c
libxl: force netback to wait for hotplug execution before connecting
2022-01-27 13:51:19 +01:00
libxl_no_colo.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_no_convert_callout.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_nocpuid.c
libxl: don't ignore the return value from xc_cpuid_apply_policy
2021-05-04 18:35:35 +01:00
libxl_nonetbuffer.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_numa.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_osdeps.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_paths.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_pci.c
libxl/PCI: Fix PV hotplug & stubdom coldplug
2022-01-13 14:33:16 +01:00
libxl_psr.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_pvcalls.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_qmp.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_remus_disk_drbd.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_remus.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_save_callout.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_save_helper.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_save_msgs_gen.pl
tools: remove tabs from code produced by libxl_save_msgs_gen.pl
2021-02-08 16:28:34 +00:00
libxl_sched.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_setresuid.c
libs/light: make it build without setresuid()
2021-01-29 22:50:08 +00:00
libxl_sr_stream_format.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_stream_read.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
libxl_stream_write.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_test_fdevent.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_test_fdevent.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_test_timedereg.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_test_timedereg.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_tmem.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_types_internal.idl
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_types.idl
gnttab: allow setting max version per-domain
2021-11-08 15:10:05 +00:00
libxl_usb.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_utils.c
tools: Use config.h from autoconf instead of "buildmakevars2header"
2021-12-16 20:27:12 +00:00
libxl_uuid.c
libs/light: fix uuid on NetBSD
2021-01-29 22:50:08 +00:00
libxl_vdispl.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_vkb.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_vnuma.c
tools/libs: merge xenctrl_dom.h into xenguest.h
2020-10-01 13:58:42 +02:00
libxl_vsnd.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_vtpm.c
libxl: s/pcidev/pci and remove DEFINE_DEVICE_TYPE_STRUCT_X
2020-12-15 16:24:16 +00:00
libxl_x86_acpi.c
tools/libxl: Correctly align the ACPI tables
2021-09-24 11:07:50 +01:00
libxl_x86_acpi.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl_x86.c
tools/libxl: Modify libxl__arch_domain_init_hw_description...
2021-10-15 12:40:21 -07:00
libxl_xshelp.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
libxl.c
tools/libs/light: replace _libxl_list.h with _xen_list.h
2022-02-08 11:10:52 +00:00
Makefile
tools/libs: Fix build dependencies
2022-02-08 11:15:53 +00:00
osdeps.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
test_common.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
test_common.h
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
test_fdderegrace.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00
test_timedereg.c
tools/libxl: move libxenlight to tools/libs/light
2020-10-01 13:26:09 +02:00