Files
xen/tools
George Dunlap ef498d99bb libxl: Fix uninitialized pointer when passing an empty cdrom
Commit 3fec17d4bb introduced a bug where
an empty cdrom would cause target_path to be uninitialized.  Initialize
target_path to NULL instead.

The other option here would have been to set target_path to NULL only
on the LIBXL_DISK_FORMAT_EMPTY path.  That would potentially enable
the compiler to catch future uninitialized paths, rather than having
those paths (potentially) dereference a NULL pointer.  But given that
a bunch of our compilers failed to catch *this* uninitialized path,
setting it to NULL at declaration seems the safer option for now.

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: George Dunlap <george.dunlap@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
2016-04-06 14:46:54 +01:00
..
2015-12-18 09:49:43 -05:00
2016-03-22 16:56:51 -04:00
2016-03-29 13:04:43 -04:00
2016-03-14 13:02:56 +01:00
2016-02-11 15:12:18 +00:00