libxl: Do not trust frontend for nic in libxl_devid_to_device_nic

Find the backend by reading the pointer in /libxl rather than in the
guest's frontend area.

This is part of XSA-175.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
This commit is contained in:
Ian Jackson authored and Ian Jackson committed 2016-06-06 15:54:27 +01:00
1 parent 9b7d6d20bc
commit 04e831a92b
1 file changed
+5 -5
+5 -5
View File
@@ -3066,17 +3066,17 @@ int libxl_devid_to_device_nic(libxl_ctx *ctx, uint32_t domid,
int devid, libxl_device_nic *nic)
{
GC_INIT(ctx);
char *dompath, *path;
char *libxl_dom_path, *path;
int rc = ERROR_FAIL;
libxl_device_nic_init(nic);
dompath = libxl__xs_get_dompath(gc, domid);
if (!dompath)
libxl_dom_path = libxl__xs_libxl_path(gc, domid);
if (!libxl_dom_path)
goto out;
path = libxl__xs_read(gc, XBT_NULL,
libxl__sprintf(gc, "%s/device/vif/%d/backend",
dompath, devid));
GCSPRINTF("%s/device/vif/%d/backend", libxl_dom_path,
devid));
if (!path)
goto out;
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.