stubdom: Fix stubdom-dm using "grep" improperly

stubdom-dm uses "grep" on "xm list" output to determine whether it is
already running. The existing behavior is to use "grep $domname-dm" but
this will result in a false-positive in the case of another domU running
whose name ends with the full new name; for instance, if "abctest-dm" is
running, a new "test-dm" will spin forever, waiting for it the end.

Any easy fix is to have it use "grep -w" instead of "grep", searching
for the whole word only.

It also might be worth considering a switch to "xl list" from "xm list",
here and in other places.

Signed-off-by: John Weekes <lists.xen@nuclearfallout.net>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
This commit is contained in:
John Weekes committed 2011-01-11 16:42:41 +00:00
1 parent b3c8bef7a7
commit 1676d94292
1 file changed
+1 -1
+1 -1
View File
@@ -91,7 +91,7 @@ trap term SIGHUP
############
# stubdomain
# Wait for any previous stubdom to terminate
while xm list | grep $domname-dm
while xm list | grep -w $domname-dm
do
sleep 1
done
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.