mirror of
https://github.com/xen-project/xen.git
synced 2026-10-29 10:40:03 +01:00
tools/firmware: remove "_PS0/3" Method
Do not expose the ACPI power management "_PS0/3" Method to guest firmware. According to section 3.4 of the APCI specification 4.0, PCI device control the device power through its own specification but not through APCI. Qemu pushes "_PS0/3" to guest will cause a mess between ACPI PM and PCI PM as a result of incorrect ACPI table shipped with the guest BIOS, it may cause a failure of PCI device PM state transition(from PCI_UNKNOWN to PCI_D0). Signed-off-by: Xudong Hao <xudong.hao@intel.com> Signed-off-by: Haitao Shan <haitao.shan@intel.com> Committed-by: Keir Fraser <keir@xen.org> xen-unstable changeset: 24357:832fa3f35432 xen-unstable date: Mon Dec 05 19:35:06 2011 +0000
This commit is contained in:
1 parent
190a3d3f8e
commit
17eb36c92e
1 file changed
-10
@@ -251,8 +251,6 @@ int main(int argc, char **argv)
|
||||
* the ACPI event:
|
||||
* _EJ0: eject a device
|
||||
* _STA: return a device's status, e.g. enabled or removed
|
||||
* Other methods are optional:
|
||||
* _PS0/3: put them here for debug purpose
|
||||
*
|
||||
* Eject button would generate a general-purpose event, then the
|
||||
* control method for this event uses Notify() to inform OSPM which
|
||||
@@ -271,14 +269,6 @@ int main(int argc, char **argv)
|
||||
stmt("Name", "_ADR, 0x%08x", ((slot & ~7) << 13) | (slot & 7));
|
||||
/* _SUN == dev */
|
||||
stmt("Name", "_SUN, 0x%08x", slot >> 3);
|
||||
push_block("Method", "_PS0, 0");
|
||||
stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
|
||||
stmt("Store", "0x80, \\_GPE.DPT2");
|
||||
pop_block();
|
||||
push_block("Method", "_PS3, 0");
|
||||
stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
|
||||
stmt("Store", "0x83, \\_GPE.DPT2");
|
||||
pop_block();
|
||||
push_block("Method", "_EJ0, 1");
|
||||
stmt("Store", "0x%02x, \\_GPE.DPT1", slot);
|
||||
stmt("Store", "0x88, \\_GPE.DPT2");
|
||||
|
||||