xen/arm: vsmc: The function identifier is always 32-bit

On Arm64, the SMCCC function identifier is always stored in the first 32-bit
of x0 register. The rest of the bits are not defined and should be
ignored.

This means the variable funcid should be an uint32_t rather than
register_t.

Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
(cherry picked from commit 7f4217cc60)
This commit is contained in:
Julien Grall authored and Stefano Stabellini committed 2019-10-29 11:39:20 -07:00
1 parent ce7b549d23
commit 1b1609327d
1 file changed
+2 -2
+2 -2
View File
@@ -181,7 +181,7 @@ static bool vsmccc_handle_call(struct cpu_user_regs *regs)
{
bool handled = false;
const union hsr hsr = { .bits = regs->hsr };
register_t funcid = get_user_reg(regs, 0);
uint32_t funcid = get_user_reg(regs, 0);
/*
* Check immediate value for HVC32, HVC64 and SMC64.
@@ -240,7 +240,7 @@ static bool vsmccc_handle_call(struct cpu_user_regs *regs)
if ( !handled )
{
gprintk(XENLOG_INFO, "Unhandled SMC/HVC: %08"PRIregister"\n", funcid);
gprintk(XENLOG_INFO, "Unhandled SMC/HVC: %#x\n", funcid);
/* Inform caller that function is not supported. */
set_user_reg(regs, 0, ARM_SMCCC_ERR_UNKNOWN_FUNCTION);
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.