mirror of
https://github.com/xen-project/xen.git
synced 2026-10-30 03:00:05 +01:00
x86/ELF: don't store function pointer in elf_core_save_regs()
This keeps at least gcc 10 from generating a separate function instance in common/kexec.o alongside the inlining of the function in its sole caller. I also think putting the address of the actual code storing the registers is a better indication to consumers than that of an otherwise unreferenced function. Signed-off-by: Jan Beulich <jbeulich@suse.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
This commit is contained in:
1 parent
5be4ce01d0
commit
1e15dcfbae
1 file changed
+1
-1
@@ -54,7 +54,7 @@ static inline void elf_core_save_regs(ELF_Gregset *core_regs,
|
||||
asm volatile("movq %%rsi,%0" : "=m"(core_regs->rsi));
|
||||
asm volatile("movq %%rdi,%0" : "=m"(core_regs->rdi));
|
||||
/* orig_rax not filled in for now */
|
||||
core_regs->rip = (unsigned long)elf_core_save_regs;
|
||||
asm ( "call 0f; 0: popq %0" : "=m" (core_regs->rip) );
|
||||
core_regs->cs = read_sreg(cs);
|
||||
asm volatile("pushfq; popq %0" :"=m"(core_regs->rflags));
|
||||
asm volatile("movq %%rsp,%0" : "=m"(core_regs->rsp));
|
||||
|
||||