xen/arm: gnttab: use static inlines for gnttab_{release_}host_mapping*

Function unmap_common_complete (common/grant_table.c) defines and sets
a variable ld that is later on passed to a macro:
gnttab_host_mapping_get_page_type().
On Arm this macro does not make use of any arguments causing a compiler
to warn about unused-but-set variable (when -Wunused-but-set-variable
is enabled). Fix it by converting this macro to a static inline
helper and using the boolean return type.

While there, also convert macro gnttab_release_host_mappings.

Signed-off-by: Michal Orzel <michal.orzel@arm.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Julien Grall <jgrall@amazon.com>
This commit is contained in:
Michal Orzel authored and Julien Grall committed 2022-05-12 18:33:27 +01:00
1 parent 407b13a71e
commit 207abdb38e
1 file changed
+12 -2
+12 -2
View File
@@ -29,12 +29,22 @@ static inline void gnttab_mark_dirty(struct domain *d, mfn_t mfn)
#endif
}
static inline bool gnttab_host_mapping_get_page_type(bool ro,
const struct domain *ld,
const struct domain *rd)
{
return false;
}
static inline bool gnttab_release_host_mappings(const struct domain *d)
{
return true;
}
int create_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
unsigned int flags, unsigned int cache_flags);
#define gnttab_host_mapping_get_page_type(ro, ld, rd) (0)
int replace_grant_host_mapping(unsigned long gpaddr, mfn_t mfn,
unsigned long new_gpaddr, unsigned int flags);
#define gnttab_release_host_mappings(domain) 1
/*
* The region used by Xen on the memory will never be mapped in DOM0
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.