mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
xen/arm: setup_dt_irq: don't enable the IRQ if the creation has failed
For now __setup_dt_irq can only fail if the action is already set. If in the future, the function is updated we don't want to enable the IRQ. Assuming the function can fail with action = NULL, when Xen will receive the IRQ it will segfault because do_IRQ doesn't check if action is NULL. Signed-off-by: Julien Grall <julien.grall@linaro.org> Acked-by: Ian Campbell <ian.campbell@citrix.com>
This commit is contained in:
1 parent
d600fcea49
commit
2cf484cee0
1 file changed
+2
-2
+2
-2
@@ -608,8 +608,8 @@ int __init setup_dt_irq(const struct dt_irq *irq, struct irqaction *new)
|
||||
rc = __setup_irq(desc, irq->irq, new);
|
||||
spin_unlock_irqrestore(&desc->lock, flags);
|
||||
|
||||
desc->handler->startup(desc);
|
||||
|
||||
if ( !rc )
|
||||
desc->handler->startup(desc);
|
||||
|
||||
return rc;
|
||||
}
|
||||
|
||||