x86/HPET: mask interrupt while changing affinity

While being unable to reproduce the "No irq handler for vector ..."
messages observed on other systems, the change done by 5dc3fd2 ('x86:
extend diagnostics for "No irq handler for vector" messages') appears
to point at the lack of masking - at least I can't see what else might
be wrong with the HPET MSI code that could trigger these warnings.

While at it, also adjust the message printed by aforementioned commit
to not pointlessly insert spaces - we don't need aligned tabular output
here.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
This commit is contained in:
Jan Beulich committed 2013-03-18 17:13:32 +01:00
1 parent e9f3de0b9c
commit 2d8a2823f3
2 files changed
+3 -1

No files matched your search

+2
View File
@@ -466,7 +466,9 @@ static void set_channel_irq_affinity(const struct hpet_event_channel *ch)
ASSERT(!local_irq_is_enabled());
spin_lock(&desc->lock);
hpet_msi_mask(desc);
hpet_msi_set_affinity(desc, cpumask_of(ch->cpu));
hpet_msi_unmask(desc);
spin_unlock(&desc->lock);
}
+1 -1
View File
@@ -826,7 +826,7 @@ void do_IRQ(struct cpu_user_regs *regs)
if ( ~irq < nr_irqs && irq_desc_initialized(desc) )
{
spin_lock(&desc->lock);
printk("IRQ%d a=%04lx[%04lx,%04lx] v=%02x[%02x] t=%-15s s=%08x\n",
printk("IRQ%d a=%04lx[%04lx,%04lx] v=%02x[%02x] t=%s s=%08x\n",
~irq, *cpumask_bits(desc->affinity),
*cpumask_bits(desc->arch.cpu_mask),
*cpumask_bits(desc->arch.old_cpu_mask),
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.