mirror of
https://github.com/xen-project/xen.git
synced 2026-10-28 02:01:24 +01:00
ioreq: don't wrongly claim "success" in ioreq_send_buffered()
Returning a literal number is a bad idea anyway when all other returns
use IOREQ_STATUS_* values. The function is dead on Arm, and mapping to
X86EMUL_OKAY is surely wrong on x86.
Fixes: f6bf39f84f ("x86/hvm: add support for broadcast of buffered ioreqs...")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Julien Grall <jgrall@amazon.com>
This commit is contained in:
1 parent
011814bd45
commit
2e0b545b84
1 file changed
+2
-2
+2
-2
@@ -1175,7 +1175,7 @@ static int ioreq_send_buffered(struct ioreq_server *s, ioreq_t *p)
|
||||
return IOREQ_STATUS_UNHANDLED;
|
||||
|
||||
/*
|
||||
* Return 0 for the cases we can't deal with:
|
||||
* Return UNHANDLED for the cases we can't deal with:
|
||||
* - 'addr' is only a 20-bit field, so we cannot address beyond 1MB
|
||||
* - we cannot buffer accesses to guest memory buffers, as the guest
|
||||
* may expect the memory buffer to be synchronously accessed
|
||||
@@ -1183,7 +1183,7 @@ static int ioreq_send_buffered(struct ioreq_server *s, ioreq_t *p)
|
||||
* support data_is_ptr we do not waste space for the count field either
|
||||
*/
|
||||
if ( (p->addr > 0xfffffUL) || p->data_is_ptr || (p->count != 1) )
|
||||
return 0;
|
||||
return IOREQ_STATUS_UNHANDLED;
|
||||
|
||||
switch ( p->size )
|
||||
{
|
||||
|
||||