[NET] gso: Fix rcv mss estimate

I noticed that with default TCP window sizes TSO + Xen would slow to a
crawl on certain machines.  It turned out that there is a bug in the
TCP stack when it comes to receiving LRO (counter part of TSO for rx)
packets.

The following fix has been applied upstream.

        [TCP]: Fix rcv mss estimate for LRO

        By passing a Linux-generated TSO packet straight back into
        Linux, Xen
        becomes our first LRO user :) Unfortunately, there is at least
        one spot
        in our stack that needs to be changed to cope with this.

        The receive MSS estimate is computed from the raw packet
        size.  This is
        broken if the packet is GSO/LRO.  Fortunately the real MSS can
        be found
        in gso_size so we simply need to use that if it is non-zero.

        Real LRO NICs should of course set the gso_size field in
        future.

        Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
kfraser@localhost.localdomain committed 2006-10-20 10:46:37 +01:00
1 parent f7d2be903b
commit 2e6d2d7144
1 file changed
+13
@@ -0,0 +1,13 @@
diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
index 104af5d..1fa1536 100644
--- a/net/ipv4/tcp_input.c
+++ b/net/ipv4/tcp_input.c
@@ -127,7 +127,7 @@ static void tcp_measure_rcv_mss(struct s
/* skb->len may jitter because of SACKs, even if peer
* sends good full-sized frames.
*/
- len = skb->len;
+ len = skb_shinfo(skb)->gso_size ?: skb->len;
if (len >= icsk->icsk_ack.rcv_mss) {
icsk->icsk_ack.rcv_mss = len;
} else {
Reference in new issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.